fix: 修复clendar中color属性继承问题&顶部svg使用Image标签#3447
fix: 修复clendar中color属性继承问题&顶部svg使用Image标签#3447xiyehutao merged 2 commits intojdf2e:feat_v3.x_cpp_orderfrom
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough将包版本从 Changes
Estimated code review effort🎯 3 (中等) | ⏱️ ~25 分钟 Possibly related PRs
Suggested reviewers
庆祝诗
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/packages/calendar/calendar.scss`:
- Around line 136-143: Weekend selectors (&:nth-child(7n + 0), &:nth-child(7n +
1)) are more specific than the disabled rules so disabled/choose-disabled text
can incorrectly stay $color-primary; update the stylesheet so disabled states
take precedence by adding more specific selectors for the disabled variants
(e.g. target .disabled and .choose-disabled combined with the weekend selector
or make the disabled selectors appear after the weekend block) and explicitly
set the inner elements .nut-calendar-day-day and .nut-calendar-day-info-curr to
the disabled text color to ensure the disabled state overrides the weekend
color.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7b854a2b-b6a2-4c55-9053-47b4622181b8
📒 Files selected for processing (4)
package.jsonsrc/packages/calendar/calendar.scsssrc/packages/calendarcard/calendarcard.scsssrc/packages/calendarcard/icon.taro.tsx
🤔 这个变动的性质是?
Summary by CodeRabbit
发布说明
版本更新
Bug 修复
优化