Merged
Conversation
xiaoyatong
reviewed
Apr 11, 2023
src/packages/griditem/griditem.tsx
Outdated
src/packages/griditem/griditem.tsx
Outdated
Collaborator
There was a problem hiding this comment.
border废弃后,这部分的样式考虑下是否还需要~
xiaoyatong
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1、子组件使用方式改为 Grid.Item
2、移除 fontSize、color 属性
3、columnNum -> columns
4、移除 border 属性,默认带边框
5、移除 icon
6、更新单元测试