Skip to content

Implement gRPC translation client#5

Merged
jdfalk merged 1 commit intomainfrom
codex/review-readme,-changelog,-technical_design,-todo
Jun 7, 2025
Merged

Implement gRPC translation client#5
jdfalk merged 1 commit intomainfrom
codex/review-readme,-changelog,-technical_design,-todo

Conversation

@jdfalk
Copy link
Copy Markdown
Owner

@jdfalk jdfalk commented Jun 7, 2025

Summary

  • implement gRPC-based translation provider
  • add --grpc flag to translate command
  • update README to document remote translation option
  • note gRPC client status in TODO
  • test gRPC provider

Testing

  • go test ./...

https://chatgpt.com/codex/tasks/task_e_68438d582fd08321b322e317b21519dc

@jdfalk jdfalk added the codex Created or modified by AI/automation agents label Jun 7, 2025 — with ChatGPT Codex Connector
@jdfalk jdfalk requested a review from Copilot June 7, 2025 00:59
@jdfalk jdfalk merged commit ecb1940 into main Jun 7, 2025
@jdfalk jdfalk deleted the codex/review-readme,-changelog,-technical_design,-todo branch June 7, 2025 01:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for a remote gRPC translation provider alongside existing services, updates the CLI and docs, and includes tests for the new client.

  • Introduce GRPCTranslate in translator.go and wire it into the provider map
  • Extend the translate command (--grpc flag) and update server stub
  • Update tests to cover gRPC provider, README, and TODO

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/translator/translator.go Added GRPCTranslate, imported gRPC packages, and extended Translate signature
pkg/translator/translator_test.go Updated Translate calls, added TestGRPCTranslate and provider test
cmd/translate.go Added --grpc flag, bound grpc_addr, and updated Translate invocation
cmd/grpcserver/main.go Adjusted server handler to call Translate with empty grpcAddr
TODO.md Marked gRPC client implementation status
README.md Documented the --grpc flag for remote translation
Comments suppressed due to low confidence (2)

cmd/translate.go:66

  • [nitpick] Flag name --grpc is ambiguous; consider renaming to --grpc-addr to clearly indicate it expects a server address.
translateCmd.Flags().String("grpc", "", "use remote gRPC translator at host:port")

pkg/translator/translator.go:108

  • The code uses context.Background() but context is not imported; add import "context" to the import block.
resp, err := client.Translate(context.Background(), &pb.TranslateRequest{

@github-actions
Copy link
Copy Markdown
Contributor

Issue closed via automated workflow.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2025

Issue closed via automated workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Created or modified by AI/automation agents

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants