First command decoupling API from CLI: all_droplets #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required that the `terminal-table` Gem be added to the Gemspec.
DataRequest simply returned the unparsed JSON string retrieved via the API, without parsing it into an object with `#body` and `#status` readers. We had a test-focus line inadvertently left in that prevented us from seeing this, and several other problems. Fixes continuing.
This shadows the existing $DO_API_TOKEN environment variable; the next commit will switch to using it instead of accessing `ENV['DO_API_TOKEN']` directly. Why, you ask? Using this *should* let Just Anyone™ clone the repo while keeping secure data secure; a commented-out "definition" suggests a way forward to the incompletely-knowledgeable user.
Also a mild refactoring/cleanup.
Defaulting to non-stubbed, obviously. Also eliminate `api_token` parameter, since it's now retrieved from Chamber or environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second item on the list in Issue #1, supporting CLI usage as specified in the documentation for the All Droplets command.
Some lights that should have come on years ago are slowly flickering to life; maybe we can burn this bike-shed down one of these days.