Cli regen models #202
Merged
Cli regen models #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rgreinho
force-pushed
the
cli-regen-models
branch
3 times, most recently
from
1eee7b8 to
8eb155b
Compare
Contributor
Author
|
I added more unit tests, but they are almost purely to reach 100% coverage... 🤔 |
Adds a subcommand to generate models based off of an OpenApi specification file.
rgreinho
force-pushed
the
cli-regen-models
branch
from
8eb155b to
6078eeb
Compare
Contributor
Author
|
Alright, I think this one is good to go as well! 💪 |
Owner
|
Good work 😄 |
jdkandersson
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a second command to regenerate the models file.
Adding a second command was useful to see which parts could be refactored and tested. I added a new marker for the
cliand re-ordered them alphabetically to make it easier to look for them.Out of curiosity, since you write all your test comments in the cucumber style, why don't you use a BDD framework?