MVVM-Update bottom sheet implementation and dependencies#7
Merged
Conversation
- Added `Plugin.Maui.BottomSheet` package and removed `The49.Maui.BottomSheet`. - Modified `MauiProgram.cs` to configure bottom sheet behavior and introduced `RegisterBottomSheets` method. - Updated `AvatarSelectViewModel` to use `IBottomSheetNavigationService` for navigation. - Refactored `PersonAddEditViewModel` to utilize the new navigation service. - Adjusted XAML and code-behind for `AvatarSelectBottomSheet` to align with the new bottom sheet implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Introduced `CacheDirectory` property in `Files.cs` for centralized access to the cache directory path. - Updated namespace in `MediaPickerRepository.cs` to include `HangTab.Constants`. - Refactored `TakePhotoAsync` method for improved readability and flow. - Modified `SavePhotoToDiskAsync` to use `Files.CacheDirectory` for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin.Maui.BottomSheetpackage and removedThe49.Maui.BottomSheet.MauiProgram.csto configure bottom sheet behavior and introducedRegisterBottomSheetsmethod.AvatarSelectViewModelto useIBottomSheetNavigationServicefor navigation.PersonAddEditViewModelto utilize the new navigation service.AvatarSelectBottomSheetto align with the new bottom sheet implementation.