fix: Doctor falsely detects stale build in other monorepos#138
Merged
Conversation
…ges/cli The CLI build status check assumed any repo with packages/cli/package.json was the vibe-validate source tree. This caused false "Build is stale" errors when running `vv doctor` from other monorepos (e.g., vibe-agent-toolkit) that also have a packages/cli/ directory. Now verifies the package name is @vibe-validate/cli before comparing versions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 85.72% 85.72%
=======================================
Files 115 115
Lines 14903 14910 +7
Branches 3215 3217 +2
=======================================
+ Hits 12775 12782 +7
Misses 2128 2128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Extract mockCliBuildSyncFs helper to eliminate duplication between build sync tests. Normalizes backslashes for Windows compatibility. Co-Authored-By: Claude <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vv doctorassumed any repo withpackages/cli/package.jsonwas the vibe-validate source treepackages/cli/directory@vibe-validate/clibefore comparing versionsTest plan
should skip check when packages/cli exists but is not vibe-validatenamefield in mock package.jsonpnpm validatepasses🤖 Generated with Claude Code