Skip to content

docs: dedupe colliding PR templates (JDWLABS-32)#10

Merged
jdwillmsen merged 1 commit into
mainfrom
fix/JDWLABS-32-pr-template
Jun 7, 2026
Merged

docs: dedupe colliding PR templates (JDWLABS-32)#10
jdwillmsen merged 1 commit into
mainfrom
fix/JDWLABS-32-pr-template

Conversation

@jdwillmsen
Copy link
Copy Markdown
Member

Summary

The apps repo tracked two PR templates that collide on case-insensitive filesystems: .github/PULL_REQUEST_TEMPLATE.md and .github/pull_request_template.md (different content). On Windows only one exists on disk, so git permanently reports the other as modified — the phantom that silently got swept into git commit -a earlier this session.

Closes JDWLABS-32. Part of epic JDWLABS-22.

Changes

  • Remove the older lowercase pull_request_template.md.
  • Keep the canonical monorepo-specific PULL_REQUEST_TEMPLATE.md, merging the lowercase template's extras into it: perf/ci/revert/style commit types and a 'No secrets or credentials in the diff' checklist item.

Verification

  • git ls-tree HEAD .github/ shows a single PULL_REQUEST_TEMPLATE.md entry (case-sensitive remote view).
  • ✅ Fresh worktrees will no longer show a phantom modified template.

🤖 Generated with Claude Code

The repo tracked both .github/PULL_REQUEST_TEMPLATE.md and
.github/pull_request_template.md with different content. On
case-insensitive filesystems only one exists on disk, so git
permanently reports the other as modified — a trap that silently
captures the phantom into 'git commit -a'.

Remove the older lowercase duplicate and keep the canonical uppercase
template, merging the lowercase extras into it (perf/ci/revert/style
commit types and a 'no secrets in the diff' checklist item).

Closes JDWLABS-32. Refs JDWLABS-22.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 7, 2026

View your CI Pipeline Execution ↗ for commit 2d9af0b

Command Status Duration Result
nx affected -t build ✅ Succeeded <1s View ↗
nx affected -t lint test ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-07 02:55:52 UTC

@jdwillmsen jdwillmsen merged commit 28c5ed6 into main Jun 7, 2026
2 checks passed
@jdwillmsen jdwillmsen deleted the fix/JDWLABS-32-pr-template branch June 7, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant