build: project structure, conventions & AI guardrails uplift (JDWLABS-11)#5
Merged
Conversation
Moved 6 shell scripts and docker/ subdir to scripts/ per JDWLABS-11. Added scripts/ to .nxignore so Nx does not scan it for projects. tools/ now contains only agents/ (Nx-adjacent Docker agent).
…pts/ (JDWLABS-11)
…e boundary rule (JDWLABS-11)
d774557 to
8359d74
Compare
Contributor
Contributor
|
View your CI Pipeline Execution ↗ for commit 8359d74
☁️ Nx Cloud last updated this comment at |
1 similar comment
Contributor
|
View your CI Pipeline Execution ↗ for commit 8359d74
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
✅ The fix from Nx Cloud was applied
We ran nx format:write to reformat .commitlintrc.json, which the PR introduced with lines exceeding Prettier's 80-character print width. The type-enum and subject-case rule arrays are now expanded across multiple lines, satisfying the format:check gate.
Tip
✅ We verified this fix by re-running nx-cloud record -- nx format:check.
Suggested Fix changes
diff --git a/.commitlintrc.json b/.commitlintrc.json
index c3f04f4..926ec52 100644
--- a/.commitlintrc.json
+++ b/.commitlintrc.json
@@ -1,9 +1,29 @@
{
"extends": ["@commitlint/config-conventional"],
"rules": {
- "type-enum": [2, "always", ["feat", "fix", "chore", "docs", "style", "refactor", "perf", "test", "build", "ci", "revert"]],
+ "type-enum": [
+ 2,
+ "always",
+ [
+ "feat",
+ "fix",
+ "chore",
+ "docs",
+ "style",
+ "refactor",
+ "perf",
+ "test",
+ "build",
+ "ci",
+ "revert"
+ ]
+ ],
"scope-case": [2, "always", "kebab-case"],
- "subject-case": [2, "never", ["sentence-case", "start-case", "pascal-case", "upper-case"]],
+ "subject-case": [
+ 2,
+ "never",
+ ["sentence-case", "start-case", "pascal-case", "upper-case"]
+ ],
"subject-empty": [2, "never"],
"subject-full-stop": [2, "never", "."],
"header-max-length": [2, "always", 100],
➡️ This fix was applied by Jake Willmsen
🎓 Learn more about Self-Healing CI on nx.dev
…WLABS-11) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
be8e46d to
875b1df
Compare
…ts (JDWLABS-11)
- Move docs/ai/{architecture,conventions,onboarding,workflows}.md to docs/
(not AI-only content; general dev reference)
- Replace ASCII service map and CI/CD flow with Mermaid diagrams
- Remove hardcoded scope name list from CLAUDE.md; point to project.json
and `pnpm exec nx show projects` as canonical source
- Remove hardcoded Angular app list from workflows.md serve command
- Fix .eslintrc.json refs -> eslint.config.ts in CLAUDE.md, AGENT.md, onboarding.md
- Add note in conventions.md that .commitlintrc.json is source of truth for commit types
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/fromtools/→scripts/; updated 7project.jsonversion targets; addedscripts/to.nxignoreso Nx ignores itpnpm run commit), lint-staged pre-commit hook, CI commit message validation on PRsCLAUDE.md,AGENT.md,docs/ai/(architecture, conventions, workflows, onboarding), and.github/PULL_REQUEST_TEMPLATE.mdframework:angularmodule boundary rules to.eslintrc.json— surfaced a real pre-existing violation (scope:rolesuiimporting fromscope:usersui) and fixed it by movingdateFilterComparator/dateSortComparatortoscope:sharedType of Change
build— build system or CI changedocs— documentation onlyfix— bug fix (cross-scope boundary violation in rolesui)ci— CI changeTest Plan
pnpm exec nx run-many -t lint test— all 21 projects passpnpm exec nx format:check— passesecho "feat(auth): add login" | pnpm exec commitlintexits 0;echo "added stuff" | pnpm exec commitlintexits 1angular-rolesui-feature-coreresolved and lint passesChecklist
feat(scope): subject)pnpm exec nx format:checkpassespnpm exec nx affected -t lintpassespnpm exec nx affected -t testpassestype:,scope:, andframework:tags inproject.jsonscope:containerimportingscope:authuilibs)