fix(progress): suppress UI escape codes and duplicate lines in text mode

[jdx]

Summary

Two problems made ProgressOutput::Text output (CI logs, piped output) ugly:

1. UI escape codes leaking into text-mode output. set_status(Done|Failed|Warn|DoneCustom) and stop() both call refresh_once() to force a synchronous render. refresh_once() did not check the output mode, so it always took the UI path through write_frame() — emitting ESC[NA, ESC[ND, ESC[0J cursor-control sequences. In a non-TTY log they show up as raw [9A[80D[0J text. Now refresh_once() returns early in ProgressOutput::Text; each update() already streamed the relevant line, so no information is lost.

2. Same line printed multiple times. Updating multiple props on a single job in quick succession (e.g. prop("message", ...) followed immediately by an explicit update(), common when integrators set several fields per state transition) emitted the same rendered line repeatedly. Cache the last text-mode line per job (last_text_output: Mutex<Option<String>>) and skip writes that produce identical output.

Together these collapse a 30-line block of duplicates and escape codes into clean one-line-per-state-change text-mode logs. Triggered while debugging hk's CI output — see hk#890 for the before/after.

Test plan

• cargo test --lib passes (116 tests, no regressions)
• cargo build
• Verified end-to-end via hk patch in CI

🤖 Generated with Claude Code

---

Note

Low Risk
Output-only changes scoped to progress rendering; main risk is unintentionally suppressing expected text-mode lines, mitigated by resetting the dedup cache on operation changes.

Overview
Improves ProgressOutput::Text (non-TTY/CI) output by making refresh_once() a no-op in text mode, preventing full-frame redraws that emit cursor-control escape codes.

Adds per-job text-mode output deduplication by caching the last rendered line (last_text_output) and skipping writes when repeated updates render the same string; the cache is cleared on next_operation() to ensure operation transitions still emit at least one line.

^{Reviewed by Cursor Bugbot for commit b92c083. Bugbot is set up for automated code reviews on this repo. Configure here.}

[gemini-code-assist]

Code Review

This pull request implements a mechanism to suppress duplicate output in text-mode progress reporting, which helps reduce noise in CI logs. It introduces a last_text_output field to ProgressJob to track the most recently rendered line and updates render_text_mode to skip writing if the content hasn't changed. Additionally, refresh_once is now a no-op when using text output to avoid unnecessary redraws and escape sequences. I have no feedback to provide.

[greptile-apps]

Greptile Summary

This PR fixes two text-mode (ProgressOutput::Text) rendering issues: refresh_once() now exits early in text mode to prevent cursor-movement escape codes from leaking into non-TTY logs, and render_text_mode caches the last emitted line per job to suppress consecutive identical writes. A previous comment about next_operation not resetting last_text_output was addressed in this revision.

Confidence Score: 5/5

Safe to merge — changes are scoped to text-mode rendering with no impact on UI/TTY paths.

No P0 or P1 issues found. The two fixes are logically correct and well-scoped; the previously flagged next_operation reset omission is addressed in this revision. Only a minor P2 observation about cache state after a failed write, which is an extremely unlikely edge case.

No files require special attention.

Important Files Changed

Filename	Overview
src/progress/render.rs	Adds early-return for Text mode in refresh_once() and per-job dedup cache in render_text_mode(); logic is sound, lock ordering is safe.
src/progress/job.rs	Adds last_text_output: Mutex<Option<String>> field, initializes it to None in the builder, and resets it in next_operation() — correctly handling the case where a new operation renders identically to the last line of the previous one.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[job.update / prop / set_status] --> B{output mode?}
    B -- Text --> C[render_text_mode]
    C --> D{output empty?}
    D -- yes --> E[return Ok]
    D -- no --> F{identical to last_text_output?}
    F -- yes --> G[skip / return Ok]
    F -- no --> H[update last_text_output cache]
    H --> I[acquire TERM_LOCK]
    I --> J[term.write_line]
    B -- UI/Auto --> K[notify render loop]
    K --> L[write_frame with cursor codes]
    M[set_status Done/Failed/Warn] --> A
    M --> N[refresh_once]
    N --> O{Text or Quiet or disabled?}
    O -- yes --> P[no-op / return Ok]
    O -- no --> L
    Q[next_operation] --> R[reset progress/rate state]
    R --> S[clear last_text_output = None]
    S --> A

Loading

_{Reviews (2): Last reviewed commit: "fix(progress): reset text-mode dedup cac..." | Re-trigger Greptile}