Auth prompt is triggered for non-auth provider errors (after #184) #291
Closed
TyceHerrman
started this conversation in
Ideas
Replies: 2 comments 1 reply
|
sounds good to me |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
In #184, the summary says:
While testing adding Proton Pass as provider:
auth_command = "pass-cli login --interactive")./password.Field does not exist: password/ secret-not-found class).fnoxstill printedAuthentication failed for provider ...and prompted login.Potential issue in current flow:
secret_resolver, auth prompt/retry is called on any provider error.prompt_and_run_authchecks whether prompting is enabled and whether the provider has anauth_command, but does not check if the error itself is auth-related.Proposed fix:
ProviderAuthFailed), instead of all provider errors.Field does not existtoProviderSecretNotFoundwith a field-specific hint).All reactions