fast_fail = false + depends hangs if an upstream check fails

[astei]

Minimal reproducer config:

amends "package://github.com/jdx/hk/releases/download/v1.52.0/hk@1.52.0#/Config.pkl"

fail_fast = false

local linters = new Mapping<String, Step> {
    ["fail"] {
        glob = "**/*"
        check = "exit 1"
    }
    ["should-pass"] {
        glob = "**/*"
        depends = List("fail")
        check = "exit 0"
    }
}

hooks {
    ["check"] {
        steps = linters
    }
}

This is an intentionally contrived example, but it demonstrates the bug very clearly. What I would expect is one of:

1. hk continues executing the rest of the checks, including dependents of a given check (my preference).
2. hk continues to execute other steps but doesn't invoke steps that depend on the failing step.

Instead, hk hangs because it expects to execute the should-pass step, but should-pass depends on fail and hk never schedules should-pass to run at all.

[jdx]

Thanks for the clear repro. I reproduced the hang on current main: the failing fail step completed, but because it returned before signaling its dependency watch channel, should-pass stayed blocked while fail_fast = false kept the group waiting.

I opened a draft fix in #1099. It treats failed steps as terminal for dependency scheduling when fail_fast = false, so dependents can continue running while the overall hk check still exits non-zero. I also added a timeout-guarded regression test for this exact shape.

This comment was generated by Codex.