Bug: check isn't run if file contains a null byte

[whatisaphone]

mise.toml:

[tools]
hk = "1.54.1"

hk.pkl:

amends "package://github.com/jdx/hk/releases/download/v1.54.1/hk@1.54.1#/Config.pkl"

local linters = new Mapping<String, Step> {
    ["mystep"] {
        glob = "*.bin"
        check = "exit 1" # always fail
    }
}

hooks {
    ["check"] {
        steps = linters
    }
}

steps:

git init

# This works:
touch foo.bin
hk check -a # this reports the failure from "exit 1", as expected

# This is broken:
printf '\0' > foo.bin
hk check -a # this should report the failure, but doesn't

[jdx]

Thanks for the report. The binary-file filtering is intentional by default, but the allow_binary option existed only in the Rust step model and was missing from Config.pkl, so there was no valid way to opt a step into binary files.

I opened #1190 to expose allow_binary in the Pkl schema and add regression coverage. Once merged, the example step can set allow_binary = true and it will run for the NUL-containing .bin file.

AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.

[whatisaphone]

Hmm, that seems like a questionable design. It's a failure mode where hk invisibly stops working if you accidentally add some weird characters to your text file. But that's when you need checks the most!

I'd suggest if the config only has a glob, hk should check all files matching the glob, and if the user wants this extra filtering, they can add types = List("text") (which already exists for this purpose). That way checks don't silently fail.