Skip to content

fix: ensure stash cleanup#302

Merged
jdx merged 2 commits into
mainfrom
fix-unstaged
Sep 22, 2025
Merged

fix: ensure stash cleanup#302
jdx merged 2 commits into
mainfrom
fix-unstaged

Conversation

@jdx

@jdx jdx commented Sep 22, 2025

Copy link
Copy Markdown
Owner

Ensure hk drops the created stash entry so git stash is empty after pre-commit; track the stash commit and drop that specific ref; use it for show/cat-file; add Bats assertions to verify stash list is empty after commit; remove obsolete test asserting no stash when committing from subdir; fix guard test to expand PKL_PATH; CI is green.

@jdx jdx force-pushed the fix-unstaged branch 3 times, most recently from 8aab876 to 4bbb778 Compare September 22, 2025 22:57
@jdx jdx changed the title test(pre-commit): verify pnpm-lock.yaml not committed nor stashed whe… pre-commit: ensure stash cleanup; add tests; remove subdir lockfile test Sep 22, 2025
cursor[bot]

This comment was marked as outdated.

@jdx jdx changed the title pre-commit: ensure stash cleanup; add tests; remove subdir lockfile test fix: ensure stash cleanup Sep 22, 2025
@jdx jdx merged commit 33ec7b0 into main Sep 22, 2025
5 checks passed
@jdx jdx deleted the fix-unstaged branch September 22, 2025 23:20
@jdx jdx mentioned this pull request Sep 22, 2025
jdx added a commit that referenced this pull request Sep 22, 2025
## [1.15.5](https://github.com/jdx/hk/compare/v1.15.4..v1.15.5) -
2025-09-22

### 🐛 Bug Fixes

- ensure stash cleanup by [@jdx](https://github.com/jdx) in
[#302](#302)

Co-authored-by: mise-en-dev <123107610+mise-en-dev@users.noreply.github.com>
@jdx jdx mentioned this pull request Sep 22, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 24, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [hk](https://github.com/jdx/hk) | minor | `1.13.7` -> `1.15.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>jdx/hk (hk)</summary>

### [`v1.15.5`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1155---2025-09-22)

[Compare Source](jdx/hk@v1.15.4...v1.15.5)

##### 🐛 Bug Fixes

- ensure stash cleanup by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;302](jdx/hk#302)

### [`v1.15.4`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1154---2025-09-22)

[Compare Source](jdx/hk@v1.15.3...v1.15.4)

##### 🐛 Bug Fixes

- scope staging to step job files to avoid unrelated file commits; add lockfile regression test by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;300](jdx/hk#300)

### [`v1.15.3`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1153---2025-09-21)

[Compare Source](jdx/hk@v1.15.2...v1.15.3)

##### 🐛 Bug Fixes

- prevent duplicate \_type fields in JSON cache for groups by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;297](jdx/hk#297)
- add top-level exclude property to hk.pkl by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;299](jdx/hk#299)

### [`v1.15.2`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1152---2025-09-20)

[Compare Source](jdx/hk@v1.15.1...v1.15.2)

##### 🐛 Bug Fixes

- prettier bugs; stash/unstash robustness; preserve EOF newline by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;293](jdx/hk#293)

##### 📚 Documentation

- remove references to alternative config formats by [@&#8203;jdx](https://github.com/jdx) in [5e497b6](jdx/hk@5e497b6)

### [`v1.15.1`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1151---2025-09-19)

[Compare Source](jdx/hk@v1.15.0...v1.15.1)

##### 🐛 Bug Fixes

- Skip any hunks that begin before the current position to avoid partial re-application by [@&#8203;jdx](https://github.com/jdx) in [8325a66](jdx/hk@8325a66)

### [`v1.15.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1150---2025-09-19)

[Compare Source](jdx/hk@v1.14.0...v1.15.0)

##### 🚀 Features

- **(docs)** add custom VitePress theme with unique branding by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;287](jdx/hk#287)

##### 🐛 Bug Fixes

- handle fixes and unstaged hunks in the same file by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;283](jdx/hk#283)

##### 📦️ Dependency Updates

- pin dependencies by [@&#8203;renovate\[bot\]](https://github.com/renovate\[bot]) in [#&#8203;288](jdx/hk#288)
- update actions/checkout action to v5 by [@&#8203;renovate\[bot\]](https://github.com/renovate\[bot]) in [#&#8203;289](jdx/hk#289)
- update actions/download-artifact action to v5 by [@&#8203;renovate\[bot\]](https://github.com/renovate\[bot]) in [#&#8203;290](jdx/hk#290)
- update actions/upload-pages-artifact action to v4 by [@&#8203;renovate\[bot\]](https://github.com/renovate\[bot]) in [#&#8203;291](jdx/hk#291)

### [`v1.14.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1140---2025-09-18)

[Compare Source](jdx/hk@v1.13.7...v1.14.0)

##### 🚀 Features

- centralized settings registry with codegen by [@&#8203;jdx](https://github.com/jdx) in [#&#8203;284](jdx/hk#284)

##### 🔍 Other Changes

- removed snapshot file by [@&#8203;bhanuprasad14](https://github.com/bhanuprasad14) in [0952af5](jdx/hk@0952af5)
- Extract Pkl error handling into separate method by [@&#8203;jdx](https://github.com/jdx) in [e62cb24](jdx/hk@e62cb24)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMTYuNiIsInVwZGF0ZWRJblZlciI6IjQxLjEyMi4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant