fix(openjdk): restore temporary jdk 28 ea alias#471
Conversation
📝 WalkthroughWalkthroughThis PR adds OpenJDK 28.0.0-ea entries to two platform-specific early-access JDK manifests: Linux x64 and macOS ARM64. Each entry includes checksum, creation timestamp, metadata fields, and download URL. ChangesJDK 28 EA Platform Manifests
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryThis PR manually appends two OpenJDK 28 EA build-1 entries (Linux x64 and macOS aarch64) to the EA JVM index files so the
Confidence Score: 3/5The JSON structure and schema are correct, but the SHA-256 checksums are manually crafted and not verifiably confirmed in the PR — a wrong hash will break every installation that touches these entries. Both files are well-formed and schema-consistent. The only unresolved concern is whether the two hand-written SHA-256 hashes match the actual Oracle-published values; if either is wrong, every Both Important Files Changed
Reviews (1): Last reviewed commit: "fix(openjdk): restore temporary jdk 28 e..." | Re-trigger Greptile |
| "image_type": "jdk", | ||
| "java_version": "28.0.0-ea", | ||
| "jvm_impl": "hotspot", | ||
| "url": "https://download.java.net/java/early_access/jdk28/1/GPL/openjdk-28-ea+1_linux-x64_bin.tar.gz", |
There was a problem hiding this comment.
Manually-crafted checksums are unverified in the PR
The checksums sha256:d9b2b25f… (Linux) and sha256:bd5590d5… (macOS) were hand-written and the stated validation (jq empty, git diff --check) only confirms valid JSON and whitespace — it does not confirm the hash values are correct. A wrong checksum will cause every mise install attempt to fail with a checksum-mismatch error. The authoritative SHA-256 values are published by Oracle at https://download.java.net/java/early_access/jdk28/1/GPL/openjdk-28-ea+1_linux-x64_bin.tar.gz.sha256 (and the equivalent macOS URL) — please confirm these were fetched from there.
| "vendor": "sapmachine", | ||
| "version": "13.0.2-ea.1" | ||
| }, | ||
| { |
There was a problem hiding this comment.
created_at lacks sub-second precision present in all other entries
Every other record in these files uses a microsecond-precision timestamp (e.g. "2025-03-28T22:04:28.081056"), while the new entries use only second precision ("2026-06-10T20:37:19"). If any downstream code sorts or deduplicates on created_at in combination with other fields, the inconsistent format could cause unexpected ordering. This applies to the macOS entry as well.
Summary
version = 28.0.0-easo mise can resolve the exact e2e requestfeatures: [""]corruptionWhy
core/test_java_slowasks forjava[release_type=ea]@openjdk-28.0.0-ea. After #469 reverted the bad generated data, that alias disappeared again. This restores the minimal clean rows needed for release CI and local macOS arm64 validation while a durable crawler/resolver fix is handled separately.Validation
jq empty public/api/jvm/ea/linux/x86_64.json public/api/jvm/ea/macosx/aarch64.jsongit diff --checkThis PR was generated by an AI coding assistant.
Note
Low Risk
Static JVM catalog JSON only; no runtime or auth changes, aside from which EA JDK URL mise can install.
Overview
Restores OpenJDK 28 EA catalog entries that were lost when bad generated JVM data was reverted in #469.
Adds one JDK row each to
public/api/jvm/ea/linux/x86_64.jsonandpublic/api/jvm/ea/macosx/aarch64.json, withvendor: openjdk,version/java_version: 28.0.0-ea, checksums, and download URLs fromdownload.java.net. Rows use emptyfeaturesarrays (no corruptedfeatures: [""]). Both files also get a proper closing]newline.This lets mise resolve
java[release_type=ea]@openjdk-28.0.0-eafor release CI (core/test_java_slow) and local macOS arm64 checks until crawler/resolver work lands.Reviewed by Cursor Bugbot for commit 541722e. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit