fix: improve ToolOptions parsing to support comma separated values

[roele]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @roele, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a limitation in the ToolOptions parsing logic, enabling it to correctly handle scenarios where an option's value itself contains commas. This enhancement significantly improves the flexibility and robustness of tool configuration by allowing more complex and expressive option strings to be accurately interpreted.

Highlights

• Parsing Logic Update: The parse_tool_options function has been refactored to correctly interpret comma-separated values as part of a single option's value, rather than as delimiters for new key-value pairs.
• Value Appending: The new logic introduces a mechanism to append subsequent comma-separated segments (that do not contain an equals sign) to the value of the most recently parsed key.
• New Test Case: A comprehensive test case has been added to validate the improved parsing behavior, specifically demonstrating the correct handling of options with comma-containing values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This PR improves the ToolOptions parsing logic to handle comma-separated values within option values, preventing them from being incorrectly split into separate options.

Changes:

• Modified parse_tool_options to track the current key and append subsequent comma-separated segments without '=' to the previous value
• Added comprehensive test case validating parsing of multiple options with comma-separated values

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request improves the parsing of tool options to support comma-separated values, which is a useful enhancement. However, the current implementation introduces a regression where it no longer correctly handles valueless keys (e.g., foo which should be parsed as foo=""). I've provided a suggestion to fix this regression by restoring the previous behavior for such cases while maintaining the new functionality. I also recommend adding test cases for valueless keys to prevent this from happening again.