registry: add trzsz-go (aqua:trzsz/trzsz-go)#9083
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a new tool registration for trzsz-go, providing support for both aqua and github backends. A review comment points out that the github backend requires an explicit executable mapping because the repository name differs from the binary name, which would otherwise prevent the tool from being located correctly.
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:trzsz/trzsz-go", "github:trzsz/trzsz-go"] | |||
There was a problem hiding this comment.
The github backend needs an explicit executable mapping because the repository name (trzsz-go) does not match the primary binary name (trzsz). Without [exe=trzsz], mise will fail to locate the executable within the release assets when falling back to the GitHub backend (e.g., if aqua is unavailable or disabled).
Note that since the tool is registered as trzsz-go, mise will create a shim named trzsz-go. While the aqua backend is capable of exposing all binaries defined in its registry (trzsz, trz, tsz), the github backend fallback will only provide a shim for the tool name itself. If the intention is for users to primarily use the trzsz command, naming the file trzsz.toml would be more idiomatic, though trzsz-go.toml is acceptable to specifically identify this implementation.
| backends = ["aqua:trzsz/trzsz-go", "github:trzsz/trzsz-go"] | |
| backends = ["aqua:trzsz/trzsz-go", "github:trzsz/trzsz-go[exe=trzsz]"] |
There was a problem hiding this comment.
This is false positive. trzsz-go provides three binaries, all of which are made available by mise. This is verified with mise use -g github:trzsz/trzsz-go.
Greptile SummaryThis PR adds a registry entry for Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["mise install trzsz-go"] --> B{Baked aqua registry\nhas trzsz/trzsz-go?}
B -- Yes --> C["aqua:trzsz/trzsz-go\n(primary backend)"]
B -- No / MISE_AQUA_BAKED_REGISTRY=false --> D["github:trzsz/trzsz-go\n(fallback backend)"]
C --> E["Installs trz, tsz, trzsz binaries"]
D --> E
E --> F["Test: trzsz --version\nexpected: 'trzsz go {version}'"]
Reviews (1): Last reviewed commit: "registry: add trzsz-go (aqua:trzsz/trzsz..." | Re-trigger Greptile |
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:trzsz/trzsz-go", "github:trzsz/trzsz-go"] | |||
There was a problem hiding this comment.
Consider adding aliases for primary binary names
The trzsz-go package's main end-user commands are trz and tsz. Without aliases, users who search mise use trz or mise use tsz won't find this package. The registry convention (e.g. ripgrep → rg, github-cli → gh, trzsz-ssh → tssh) is to alias the well-known binary name(s) to the package.
| backends = ["aqua:trzsz/trzsz-go", "github:trzsz/trzsz-go"] | |
| aliases = ["trz", "tsz"] | |
| backends = ["aqua:trzsz/trzsz-go", "github:trzsz/trzsz-go"] |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
trzsz has a python version which also uses these two binary names. I don't think this is a good idea.
### 🚀 Features - **(npm)** use --min-release-age for npm 11.10.0+ supply chain protection by @webkaz in [#9072](#9072) - **(registry)** add openfga by @mnm364 in [#9084](#9084) - **(task)** allow to set confirmation default by @roele in [#9089](#9089) - support os/arch compound syntax in tool os filtering by @RobertDeRose in [#9088](#9088) ### 🐛 Bug Fixes - **(activate)** export __MISE_EXE and resolve bare ARGV0 to absolute path by @fru1tworld in [#9081](#9081) - **(install)** support aliased installs sharing a backend by @jdx in [#9093](#9093) - **(shim)** use which_no_shims when resolving mise binary in reshim and doctor by @kevinswiber in [#9071](#9071) - filter empty segments in colon-separated env var parsing by @baby-joel in [#9076](#9076) ### 📚 Documentation - fix wrong file reference to forgejo backend implemenation by @roele in [#9090](#9090) - fix cli token command for token resolution by @roele in [#9077](#9077) ### 📦 Registry - add trzsz-go ([aqua:trzsz/trzsz-go](https://github.com/trzsz/trzsz-go)) by @ZeroAurora in [#9083](#9083) - add copilot ([aqua:github/copilot-cli](https://github.com/github/copilot-cli)) by @risu729 in [#9082](#9082) ### Chore - add AGENTS.md symlink by @jdx in [#9094](#9094) ### New Contributors - @kevinswiber made their first contribution in [#9071](#9071) - @webkaz made their first contribution in [#9072](#9072) - @RobertDeRose made their first contribution in [#9088](#9088) ## 📦 Aqua Registry Updates #### New Packages (7) - [`IBM-Cloud/ibm-cloud-cli-release`](https://github.com/IBM-Cloud/ibm-cloud-cli-release) - [`max-sixty/worktrunk`](https://github.com/max-sixty/worktrunk) - [`micelio.dev/hif`](https://github.com/micelio.dev/hif) - [`pgplex/pgschema`](https://github.com/pgplex/pgschema) - [`rose-pine/rose-pine-bloom`](https://github.com/rose-pine/rose-pine-bloom) - [`santosr2/TerraTidy`](https://github.com/santosr2/TerraTidy) - [`trzsz/trzsz-go`](https://github.com/trzsz/trzsz-go) #### Updated Packages (3) - [`mvdan/sh`](https://github.com/mvdan/sh) - [`rvben/rumdl`](https://github.com/rvben/rumdl) - [`temporalio/temporal`](https://github.com/temporalio/temporal)
Available in aqua as of v4.493.0.
Verified with
export MISE_AQUA_BAKED_REGISTRY=false. Should be merged after baked aqua updated.