fix(vfox): fallback to absolute bin path if env_keys not set

[80avin]

fixes #9150

[gemini-code-assist]

Code Review

This pull request updates the vfox backend to handle cases where the PATH environment variable is not explicitly provided by a plugin. The current implementation introduces a logic error by falling back to the project root's bin directory instead of the tool's specific installation path, which may cause incorrect binary resolution or regressions when operating outside of a project context.

[greptile-apps]

Greptile Summary

This PR fixes list_bin_paths in the vfox backend so that when a plugin's env_keys response does not include a PATH entry, mise falls back to the tool's absolute install directory (tv.install_path().join("bin")) instead of the previously broken relative "bin" string that was effectively useless. The change is minimal, targeted, and consistent with the intent of the default Backend::list_bin_paths implementation.

Confidence Score: 4/5

Safe to merge — fixes a real breakage with a minimal, correct change. One P2 nit on using install_path() vs runtime_path() for consistency with the default implementation.

The fix is clearly correct and addresses the reported issue. The only remaining note is a P2 style suggestion to use runtime_path() instead of install_path() to match the default trait implementation, which wouldn't affect the vast majority of cases but improves consistency.

src/backend/vfox.rs — only changed file; low risk.

Important Files Changed

Filename	Overview
src/backend/vfox.rs	Fixes list_bin_paths fallback from a useless relative "bin" string to the absolute tv.install_path().join("bin"); minor inconsistency with the default implementation's use of runtime_path() instead of install_path().

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[list_bin_paths called] --> B[_exec_env: fetch env_keys from vfox plugin]
    B --> C{PATH key present\nin env_keys?}
    C -- Yes --> D[env::split_paths on PATH value\nreturn as Vec<PathBuf>]
    C -- No --> E_new["BEFORE: return 'bin' — broken relative path\nAFTER: return tv.install_path()/bin — absolute path"]
    E_new --> F[Tool binaries found at install dir/bin]
    D --> F

Loading

_{Reviews (2): Last reviewed commit: "fix(vfox): fallback to absolute bin path..." | Re-trigger Greptile}