## Summary This PR adds comprehensive Windows support to usage by: 1. **Adding Windows build targets to releases** (resolves jdx#470) 2. **Fixing shell completions on Windows** (resolves jdx#471) ## Changes ### 1. Windows Binary Distribution Added two Windows build targets to `.github/workflows/publish-cli.yml`: - `x86_64-pc-windows-msvc` - 64-bit Intel/AMD Windows with MSVC toolchain - `aarch64-pc-windows-msvc` - ARM64 Windows (Surface Pro X, etc.) with MSVC toolchain Both targets: - Use `windows-latest` GitHub runners for native compilation - Use `cargo` as the build tool (not cross) - Produce `.zip` archives automatically via `taiki-e/upload-rust-binary-action` This follows the proven pattern from hk, pitchfork, and fnox repositories. ### 2. Cross-Platform Shell Invocation Updated `lib/src/sh.rs` to use platform-specific shell commands: - **Unix**: `sh -c` (existing behavior, unchanged) - **Windows**: `cmd /c` (new, fixes completions) Used conditional compilation (`#[cfg(unix)]` and `#[cfg(windows)]`) for clean separation. **Why `cmd.exe` and not PowerShell?** - Universally available on all Windows versions - More reliable for basic script execution - Simpler syntax, no PATH concerns - Matches patterns used by most cross-platform Rust tools ## Testing ✅ All tests pass on Linux (GitHub Actions will verify Windows builds) ✅ Cargo build successful ✅ No breaking changes to existing Unix behavior ## Impact After merging and the next release: - ✅ Windows users can download pre-built binaries instead of building from source - ✅ Completions will work on Windows for both PowerShell and other shells - ✅ Both x86_64 and ARM64 Windows devices supported - ✅ Closes jdx#470 - ✅ Closes jdx#471 ## Release Notes Windows support! This release adds: - Pre-built Windows binaries (x86_64 and ARM64) to GitHub releases - Working shell completions on Windows using cmd.exe 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>  --- > [!NOTE] > **Medium Risk** > Moderate risk because it changes the release pipeline matrix to produce Windows artifacts and alters how scripts are executed on Windows, which could affect packaging/command behavior there. > > **Overview** > Adds **native Windows builds** to the release workflow by extending `publish-cli.yml` to compile and upload `x86_64-pc-windows-msvc` and `aarch64-pc-windows-msvc` artifacts using `cargo` on `windows-latest` runners. > > Updates `lib/src/sh.rs` to invoke the platform-appropriate shell (`sh -c` on Unix, `cmd /c` on Windows) and adjusts error messages accordingly, improving Windows compatibility for any features that run shell scripts (e.g., completion generation). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2d61309. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>  Co-authored-by: Claude <noreply@anthropic.com>

Windows binaries missing from github releases #470

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions