fix(zsh): escape values without descriptions

[david-hamilton-glean]

Usage v3.1.0 introduced a regression in zsh completion. Nested tasks without descriptions would fail to complete.

❯ fd . mise/tasks
mise/tasks/test/
mise/tasks/test/git.sh
mise/tasks/test/nvim.sh

# When the files lack a #MISE description=""
❯ command usage complete-word --shell zsh -f /var/folders/8s/74f40sh52hq66ghhh3c39tz80000gn/T/usage__usage_spec_mise_2026_4_18.spec -- mise run te
test:git
test:nvim

# When the files contain a #MISE description=""
❯ command usage complete-word --shell zsh -f /var/folders/8s/74f40sh52hq66ghhh3c39tz80000gn/T/usage__usage_spec_mise_2026_4_18.spec -- mise run te
test\:git:run git tests
test\:nvim:run nvim tests

Commit ae67b38 switched zsh completions to _describe, but it only escaped completion values when any descriptions were present. This meant zsh treated nested tasks as descriptions (e.g. in test:git, "git" is interpreted as the description of the item "test").

This PR fixes the issue by always escaping zsh candidates so values like test:git remain valid _describe entries even when no description is emitted.

See: https://github.com/zsh-users/zsh-completions/blob/master/zsh-completions-howto.org#writing-simple-completion-functions-using-_describe

[gemini-code-assist]

Code Review

This pull request ensures that completion words for zsh are properly escaped even when no descriptions are provided. It moves the escaping logic for the completion word outside the conditional block and adds a regression test to verify that colons are correctly escaped in this scenario. I have no feedback to provide.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9072f2c555

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[greptile-apps]

Greptile Summary

This PR fixes a regression introduced in v3.1.0 where zsh completions would fail for nested tasks (e.g. test:git) when no descriptions were present, because zsh_escape was only applied to completion values inside the if any_descriptions block. The fix moves the zsh_escape(&c) call unconditionally before the branch, so colon-containing values are always properly escaped for _describe.

Confidence Score: 5/5

Safe to merge — the fix is minimal, correctly scoped, and covered by a new regression test.

The change is a one-line hoist of an existing escape call, no new logic is introduced, and the regression is directly tested. No P0/P1 issues found.

No files require special attention.

Important Files Changed

Filename	Overview
cli/src/cli/complete_word.rs	Moved zsh_escape(&c) unconditionally before the any_descriptions branch — minimal, correct fix for the regression.
cli/tests/complete_word.rs	New test verifies colon-containing choices are properly escaped in zsh output when no descriptions are present.
examples/zsh-colons-without-descriptions.usage.kdl	New example fixture used by the regression test; defines test:git and test:nvim choices without descriptions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[For each completion candidate c] --> B["zsh_escape(&c)  ← moved here (unconditional)"]
    B --> C{any_descriptions?}
    C -- yes --> D["zsh_escape(&description)"]
    D --> E["println!('{c}:{description}')"]
    C -- no --> F["println!('{c}')"]

    style B fill:#d4edda,stroke:#28a745

Loading

_{Reviews (1): Last reviewed commit: "fix(zsh): escape values without descript..." | Re-trigger Greptile}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.03%. Comparing base (79926cd) to head (36de73e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cli/src/cli/complete_word.rs	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   79.04%   79.03%   -0.02%     
==========================================
  Files          48       48              
  Lines        7235     7235              
  Branches     7235     7235              
==========================================
- Hits         5719     5718       -1     
+ Misses       1141     1140       -1     
- Partials      375      377       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.