Skip to content

ci: pin taiki-e/install-action to commit SHA #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Apr 30, 2026
+1 −1
Merged

ci: pin taiki-e/install-action to commit SHA #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- run: rustup component add llvm-tools-preview --toolchain stable-x86_64-unknown-linux-gnu
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov
uses: taiki-e/install-action@d79fce544138636ae8155ecac335f73c98e3b198 # cargo-llvm-cov
Copy link
Copy Markdown

@cursor cursor Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tool input when SHA-pinning install-action

High Severity

Switching taiki-e/install-action from the @cargo-llvm-cov tag ref to a commit SHA loses the tool name that was previously conveyed by the tag itself. The comment # cargo-llvm-cov is only a human-readable annotation and doesn't configure anything. Without a with: tool: cargo-llvm-cov block, the action won't know which tool to install, and the coverage workflow will fail.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 252557c. Configure here.

- name: Generate code coverage
run: mise run coverage
- name: Upload coverage to Codecov
Expand Down
Loading