Skip to content

chore(ci): assert mise run render produces no diff#632

Merged
jdx merged 1 commit into
mainfrom
chore/assert-render-clean
May 12, 2026
Merged

chore(ci): assert mise run render produces no diff#632
jdx merged 1 commit into
mainfrom
chore/assert-render-clean

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented May 12, 2026

Runs mise run render and asserts it produces no diff. Follows up the autofix.ci workflow removal in #631.

🤖 Generated with Claude Code


Note

Low Risk
Low risk: workflow-only change that adds a determinism check and may only cause new CI failures when generated artifacts are out of date.

Overview
The test GitHub Actions workflow now runs mise r render and fails the job if it changes the working tree, printing git status/git diff to help diagnose missing generated-file commits.

This effectively enforces that render outputs are kept in sync and committed as part of PRs.

Reviewed by Cursor Bugbot for commit a748d4d. Bugbot is set up for automated code reviews on this repo. Configure here.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 12, 2026

Greptile Summary

This PR adds a CI check to test.yml that runs mise r render and then asserts the working tree is clean, replacing the autofix.ci-based render workflow from #631.

  • Runs mise r render in the test job and uses git status --porcelain to detect any uncommitted output, emitting a clear ::error:: annotation and a non-zero exit code if the rendered files are stale.
  • git diff in the diagnostic block only surfaces changes to already-tracked files; new untracked files generated by render would be flagged by git status but their content would not be printed.

Confidence Score: 4/5

Safe to merge; the change is a self-contained CI gate with no runtime impact.

The logic is straightforward and correct. The only gap is that the diagnostic output (git diff) silently skips new untracked files, so a developer debugging a failure would need to inspect git status output to find them. This is a minor observability concern that does not affect the correctness of the check itself.

.github/workflows/test.yml — specifically the diagnostic output block.

Important Files Changed

Filename Overview
.github/workflows/test.yml Adds a mise r render step followed by a git status --porcelain check to assert no diff is produced; diagnostic output omits content of new untracked files.

Fix All in Claude Code

Reviews (1): Last reviewed commit: "chore(ci): assert mise run render produc..." | Re-trigger Greptile

Comment on lines +43 to +44
git status
git diff
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 git diff only shows changes to already-tracked files. If mise r render generates a brand-new file that was never committed, git status --porcelain will correctly fail the check, but the developer won't see the new file's content in the error output — only a ?? path/to/file line from git status. Consider also listing untracked file content so the error output is self-contained.

Suggested change
git status
git diff
git status
git diff
git ls-files --others --exclude-standard | xargs -r -I{} sh -c 'echo "=== new file: {} ===" && cat "{}"'

Fix in Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.94%. Comparing base (4669413) to head (a748d4d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #632   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files          49       49           
  Lines        7284     7284           
  Branches     7284     7284           
=======================================
  Hits         5750     5750           
  Misses       1147     1147           
  Partials      387      387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdx jdx merged commit dea3f39 into main May 12, 2026
7 checks passed
@jdx jdx deleted the chore/assert-render-clean branch May 12, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant