chore(ci): assert mise run render produces no diff#632
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Greptile SummaryThis PR adds a CI check to
Confidence Score: 4/5Safe to merge; the change is a self-contained CI gate with no runtime impact. The logic is straightforward and correct. The only gap is that the diagnostic output (git diff) silently skips new untracked files, so a developer debugging a failure would need to inspect git status output to find them. This is a minor observability concern that does not affect the correctness of the check itself. .github/workflows/test.yml — specifically the diagnostic output block. Important Files Changed
Reviews (1): Last reviewed commit: "chore(ci): assert mise run render produc..." | Re-trigger Greptile |
| git status | ||
| git diff |
There was a problem hiding this comment.
git diff only shows changes to already-tracked files. If mise r render generates a brand-new file that was never committed, git status --porcelain will correctly fail the check, but the developer won't see the new file's content in the error output — only a ?? path/to/file line from git status. Consider also listing untracked file content so the error output is self-contained.
| git status | |
| git diff | |
| git status | |
| git diff | |
| git ls-files --others --exclude-standard | xargs -r -I{} sh -c 'echo "=== new file: {} ===" && cat "{}"' |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 49 49
Lines 7284 7284
Branches 7284 7284
=======================================
Hits 5750 5750
Misses 1147 1147
Partials 387 387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Runs
mise run renderand asserts it produces no diff. Follows up the autofix.ci workflow removal in #631.🤖 Generated with Claude Code
Note
Low Risk
Low risk: workflow-only change that adds a determinism check and may only cause new CI failures when generated artifacts are out of date.
Overview
The
testGitHub Actions workflow now runsmise r renderand fails the job if it changes the working tree, printinggit status/git diffto help diagnose missing generated-file commits.This effectively enforces that render outputs are kept in sync and committed as part of PRs.
Reviewed by Cursor Bugbot for commit a748d4d. Bugbot is set up for automated code reviews on this repo. Configure here.