feat(spec): output KDL multiline strings for descriptions#639
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 75.34% 73.57% -1.77%
==========================================
Files 49 49
Lines 7389 7455 +66
Branches 7389 7455 +66
==========================================
- Hits 5567 5485 -82
- Misses 1217 1254 +37
- Partials 605 716 +111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces a string_entry helper function to centralize KDL string entry creation and automatically use multiline string syntax for values containing newlines. Various spec files and snapshot tests were updated to adopt this new formatting. Feedback indicates that the string_entry implementation should be hardened to handle cases where the input string contains triple-quote sequences, which would otherwise result in invalid KDL output.
Greptile SummaryThis PR refactors the KDL serialization layer to emit raw multiline strings (
Confidence Score: 5/5Safe to merge after reverting the unrelated mise.lock URL change. The multiline string logic in mise.lock — the docs URL in the auto-generated comment was changed from Important Files Changed
Reviews (4): Last reviewed commit: "feat(spec): output KDL multiline strings..." | Re-trigger Greptile |
b14e16c to
d1a903a
Compare
d1a903a to
3666a79
Compare
No description provided.