Skip to content

fix(ci): preserve release push credentials#650

Merged
jdx merged 1 commit into
mainfrom
fix/release-plz-push-auth
May 31, 2026
Merged

fix(ci): preserve release push credentials#650
jdx merged 1 commit into
mainfrom
fix/release-plz-push-auth

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented May 31, 2026

Summary

  • keep checkout credentials persisted in the release-plz workflow so git push origin release --force can authenticate

Testing

  • actionlint .github/workflows/release-plz.yml

This PR was generated by AI.


Note

Low Risk
Single CI checkout flag change with no runtime or security surface beyond using the existing release token for pushes as intended.

Overview
The release-plz workflow now sets actions/checkout persist-credentials: true instead of false, so the token from MY_RELEASE_PLEASE_TOKEN stays configured in the job’s git remote for later steps (e.g. git push origin release --force from release-plz).

No application or release logic changes—only checkout behavior for authenticated pushes.

Reviewed by Cursor Bugbot for commit 8142f68. Bugbot is set up for automated code reviews on this repo. Configure here.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@jdx jdx closed this May 31, 2026
@jdx jdx force-pushed the fix/release-plz-push-auth branch from 107638d to 8ca4f7f Compare May 31, 2026 14:01
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 31, 2026

Greptile Summary

Removes persist-credentials: false from the actions/checkout step in the release-plz workflow, restoring default credential persistence so that git push origin release --force (run inside mise run release-plz) can authenticate with the checked-out MY_RELEASE_PLEASE_TOKEN.

Confidence Score: 5/5

Safe to merge — single-line workflow change that restores default credential persistence for the release job.

The only changed file is a CI workflow, and the single-line change correctly enables credential persistence so the release script can push. The token being persisted (MY_RELEASE_PLEASE_TOKEN) is already explicitly passed to the checkout step and to the subsequent run step, so this aligns the two. No application code is touched.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release-plz.yml Changes persist-credentials from false to true on the checkout step so subsequent git push commands can authenticate using the persisted MY_RELEASE_PLEASE_TOKEN.

Reviews (2): Last reviewed commit: "fix(ci): preserve release push credentia..." | Re-trigger Greptile

@jdx jdx reopened this May 31, 2026
@jdx jdx merged commit 1920fd1 into main May 31, 2026
6 checks passed
@jdx jdx deleted the fix/release-plz-push-auth branch May 31, 2026 14:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.58%. Comparing base (8ca4f7f) to head (8142f68).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files          49       49           
  Lines        7430     7430           
  Branches     7430     7430           
=======================================
  Hits         5913     5913           
  Misses       1142     1142           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant