Skip to content

Conversation

@jeddeloh
Copy link
Owner

This branch is available via rescript-apollo-client@next. The only change is updating the reason-react dependency to @rescript/react. My plan was to wait for a proper release until any documentation (migration or otherwise) is up for it.

@jfrolich
Copy link
Collaborator

Great! Thanks, I probably will try this out in prod soon :)

@jeddeloh
Copy link
Owner Author

jeddeloh commented Feb 16, 2021

Awesome. I have to wait for bs-material-ui :)

@jeddeloh jeddeloh changed the title Next Next (@rescript/react) Feb 16, 2021
@jeddeloh
Copy link
Owner Author

I somehow missed the docs for this: https://rescript-lang.org/docs/react/latest/introduction

Still, I would like to actually be able to run the latest myself in production, so I'll plan to release when bs-material-ui does cca-io/rescript-mui#120

@@ -1 +1,4 @@
ReactDOMRe.renderToElementWithId(<App />, "root")
switch ReactDOM.querySelector("#root") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own curiosity can you get into why this change is necessary here? Thanks!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReactDOMRe is no longer available in @rescript/react. I also switched to using the pattern of loading an app pulled directly from the documentation that uses querySelector. If I were building a real app, I'd probably at least log on the None case.

Copy link

@bdunn313 bdunn313 Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks! I missed that little update with the change! I have no real power here (muahahha) but I symbolically approved :D

@jeddeloh
Copy link
Owner Author

jeddeloh commented Apr 27, 2021

Whoops, kinda forgot about this :) I'm going to publish this as latest if no one objects. I've made bs-platform an optional peer dependency in anticipation of the new rescript package and melange.

@jeddeloh jeddeloh merged commit 55934a8 into master May 2, 2021
@jeddeloh jeddeloh deleted the next branch May 2, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants