-
Notifications
You must be signed in to change notification settings - Fork 19
Next (@rescript/react) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great! Thanks, I probably will try this out in prod soon :) |
|
Awesome. I have to wait for |
|
I somehow missed the docs for this: https://rescript-lang.org/docs/react/latest/introduction Still, I would like to actually be able to run the latest myself in production, so I'll plan to release when |
| @@ -1 +1,4 @@ | |||
| ReactDOMRe.renderToElementWithId(<App />, "root") | |||
| switch ReactDOM.querySelector("#root") { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own curiosity can you get into why this change is necessary here? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReactDOMRe is no longer available in @rescript/react. I also switched to using the pattern of loading an app pulled directly from the documentation that uses querySelector. If I were building a real app, I'd probably at least log on the None case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks! I missed that little update with the change! I have no real power here (muahahha) but I symbolically approved :D
|
Whoops, kinda forgot about this :) I'm going to publish this as latest if no one objects. I've made |
This branch is available via
rescript-apollo-client@next. The only change is updating thereason-reactdependency to@rescript/react. My plan was to wait for a proper release until any documentation (migration or otherwise) is up for it.