Fix options creation for @apollo/client >= 3.5 #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illusionalsagacity
changed the title
Contributor
Author
|
Smoke tested this on a branch of my employer's app, definitely fixes the immediate crash on startup. |
jeddeloh
reviewed
Dec 21, 2021
jeddeloh
approved these changes
Dec 21, 2021
Owner
jeddeloh
left a comment
jeddeloh
left a comment
There was a problem hiding this comment.
Gonna wait to merge a bit in case you get to comments
Contributor
Author
Yeah I can get to them in a bit |
Owner
|
Excellent! Thanks again! I also tested in /EXAMPLES and things look good. I checked that mutation options already use abstract/obj but subscription doesn't. I'm going to go ahead in a subsequent PR and convert subscription as well. |
Owner
|
Oh, ignore me. You already did it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #133