improve color picker #3156
Merged
improve color picker #3156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salvialf
requested review from
Adam-Doudeau,
Hotfirenet,
Mips2648,
Sekiro-kost,
reineabs,
tmartinez69009 and
zoic21
Mips2648
approved these changes
Dec 14, 2025
kwizer15
reviewed
Dec 14, 2025
| jeedom.cmd.displayDuration(_options.valueDate, cmd.querySelector('.timeCmd'), '#time#') | ||
| } | ||
| cmd.querySelector('.action_colorpicker_change').value = (_options.display_value != '') ? _options.display_value.substr(0, 7) : '#000000' | ||
| if (_options.display_value.length == 0) { |
Contributor
There was a problem hiding this comment.
function toColor(value) {
if (value.length == 0) {
return '#000000'
}
if (value.startsWith('#')) {
return value.substr(0, 7)
}
return '#' + value.substr(0, 6)
}
cmd.querySelector('.action_colorpicker_change').value = toColor(_options.display_value)
Contributor
Author
There was a problem hiding this comment.
I don’t think this approach is appropriate. First, the function would end up duplicated across every color picker widget. In addition, none of the other widgets rely on integrated global functions, so introducing one here would be inconsistent with the existing design.
kwizer15
approved these changes
Dec 14, 2025
Hotfirenet
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3155