fix: Suppression des arguments superflus dans les appels de méthodes (PHPStan lvl 1)#3258
Merged
Mips2648 merged 1 commit intojeedom:developfrom Apr 17, 2026
Merged
Conversation
Mips2648
approved these changes
Apr 17, 2026
| ajax::success(user::removeBanIp()); | ||
| user::removeBanIp(); | ||
| ajax::success(); | ||
| } |
Collaborator
There was a problem hiding this comment.
ok, this was not an issue as such, both will work same way I think but it is more explicit and clear now
Salvialf
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suppression des arguments passés en trop lors d'appels de méthodes. Ces paramètres n'existent pas dans la signature des fonctions appelées et sont donc ignorés silencieusement par PHP. Aucun changement de comportement.
Exemples :
cache::set()appelé avec 4 args au lieu de 3history::getHistoryFromCalcul()avec un 6e argument inexistantinteractQuery::byInteractDefId()avec un 2e argument inexistantlistener::all(),queue::all(),jeeObject::getUISelectList()avec des arguments en tropjeedom::update()avec un 2e argument inexistantrepo_market::backup_restore()avec un 2e argument inexistantupdate::getLastAvailableVersion()avec un argument inexistantajax::success($return)remplacé parajax::success()quand$returnn'est pas définiuser::removeBanIp(): retour void utilisé comme argument deajax::success()Suggested changelog entry
Nettoyage des arguments superflus dans les appels de méthodes (PHPStan)
Related issues/external references
Découpage de #3122
Types of changes
PR checklist