Clean bella#128
Merged
Merged
Conversation
Delete legacy bellaMobile class and demo panelWebApp UI files, remove their include from mobile.class.php, and clean up mobile.api.php by removing the unused syncBella stub and fixing a typo in the notifications comment. This removes dead/sample code related to the Bella feature and tidies up mobile-related sources.
Include '/../desktop/php/panelWebApp.php' and '/../core/class/bellaMobile.class.php' in the mobile_update() $oldFiles array so these legacy files are removed during updates. This change ensures deprecated panel web app and mobile class files are cleaned up when running the update routine.
Add a special-case in mobile_update migration: when migrating a command with logicalId 'phoneBattery', set its 'calculValueOffset' configuration to '#value# * 100' and log the action. This ensures battery values are scaled (e.g., from fractional to percentage) as part of the existing logicalId renaming and save process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggested changelog entry
Related issues/external references
Fixes #
Types of changes
PR checklist
<!--
Please make sure your pull request passes all continuous integration checks!
PRs which are failing their CI checks will likely be ignored by the maintainers.
PRs using atomic, descriptive commits are hugely appreciated as it will make
reviewing your changes easier for the maintainers.
-->