Skip to content

Restore applyBatteryGridChargeLimit in optimizer#31

Merged
jeffborg merged 6 commits into
masterfrom
copilot/revert-load-forecast-battery
May 5, 2026
Merged

Restore applyBatteryGridChargeLimit in optimizer#31
jeffborg merged 6 commits into
masterfrom
copilot/revert-load-forecast-battery

Conversation

Copy link
Copy Markdown

Copilot AI commented May 5, 2026

  • Restore applyBatteryGridChargeLimit function
  • Restore the call site in the battery meter loop
  • Merge master to fix lint issues
  • All other jeffborg optimizer customizations unchanged

Copilot AI linked an issue May 5, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits May 5, 2026 05:54
This reverts commit 7678e23.

Co-authored-by: jeffborg <1595430+jeffborg@users.noreply.github.com>
This reverts commit 33f0d31.

Co-authored-by: jeffborg <1595430+jeffborg@users.noreply.github.com>
Copilot AI changed the title [WIP] Revert load forecast for battery for optimizer Revert load forecast for battery in optimizer May 5, 2026
Copilot AI requested a review from jeffborg May 5, 2026 06:02
@jeffborg
Copy link
Copy Markdown
Owner

jeffborg commented May 5, 2026

@copilot only want to restore applyBatteryGridChargeLimit nothing else

Keeps only the applyBatteryGridChargeLimit function restoration, not the other optimizer changes.

Co-authored-by: jeffborg <1595430+jeffborg@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented May 5, 2026

@copilot only want to restore applyBatteryGridChargeLimit nothing else

Done. Narrowed the change to only restore applyBatteryGridChargeLimit (commit be6c679). All your other optimizer customizations (planner tariff, batteryRequest(dev, b) signature, fillMissingRateSlots, rateHorizonSlots, etc.) remain untouched.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 224.0.0.251
    • Triggering command: REDACTED, pid is -1 (packet block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Revert load forecast for battery in optimizer Restore applyBatteryGridChargeLimit in optimizer May 5, 2026
Copy link
Copy Markdown
Owner

@jeffborg jeffborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applyBatteryGridChargeLimit isn't called need to put back the line which calls this which fills in slots for the optimizer

Copy link
Copy Markdown
Author

Copilot AI commented May 5, 2026

applyBatteryGridChargeLimit isn't called need to put back the line which calls this which fills in slots for the optimizer

Added the call site back in commit 1f78130. The battery meter loop now calls applyBatteryGridChargeLimit and sets bat.PDemand when grid prices are below the configured limit — placed in the outer loop where grid, minLen, and firstSlotDuration are already in scope, keeping the batteryRequest(dev, b) signature unchanged.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 224.0.0.251
    • Triggering command: REDACTED, pid is -1 (packet block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from jeffborg May 5, 2026 22:19
@jeffborg jeffborg marked this pull request as ready for review May 5, 2026 22:21
@jeffborg
Copy link
Copy Markdown
Owner

jeffborg commented May 5, 2026

@copilot merge master into this will fix lint issue

…-forecast-battery

Co-authored-by: jeffborg <1595430+jeffborg@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented May 5, 2026

@copilot merge master into this will fix lint issue

Done — merged master into the branch (commit d321e86). The 4 lint fixes from master are now included.

@jeffborg jeffborg merged commit f7450f7 into master May 5, 2026
12 checks passed
@jeffborg jeffborg deleted the copilot/revert-load-forecast-battery branch May 5, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert load forecast for battery for optimzer

2 participants