Skip to content

Increase plan minimum slot duration from 3min to 4min#32

Merged
jeffborg merged 5 commits into
masterfrom
copilot/adjust-min-slot-time
May 5, 2026
Merged

Increase plan minimum slot duration from 3min to 4min#32
jeffborg merged 5 commits into
masterfrom
copilot/adjust-min-slot-time

Conversation

Copy link
Copy Markdown

Copilot AI commented May 5, 2026 •
edited
Loading

  • Change smallSlotDuration in core/loadpoint_plan.go from 3 * time.Minute to 4 * time.Minute
  • Merged master — upstream reflect.Ptr → reflect.Pointer fix now included

Copilot AI linked an issue May 5, 2026 that may be closed by this pull request
set plan min slot to about 3.5-4 minutes from it's current 30 #30
Closed
@jeffborg
set plan min slot duration to 4 minutes
ad11f23 
Agent-Logs-Url: https://github.com/jeffborg/evcc/sessions/80e58b5e-9e81-4a1b-b5f5-3d95f4af708d

Co-authored-by: jeffborg <1595430+jeffborg@users.noreply.github.com>
Copilot AI changed the title [WIP] Update plan minimum slot to 3.5-4 minutes Increase plan minimum slot duration from 3min to 4min May 5, 2026
Copilot AI requested a review from jeffborg May 5, 2026 05:41
@jeffborg
Copy link
Copy Markdown
Owner

jeffborg commented May 5, 2026

@copilot linter fails

@jeffborg
fix reflect.Ptr deprecated usage to fix linter
ebb9cbd 
Agent-Logs-Url: https://github.com/jeffborg/evcc/sessions/2a6e3659-01e7-4040-a943-26f63dee4e0c

Co-authored-by: jeffborg <1595430+jeffborg@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented May 5, 2026

@copilot linter fails

Fixed in ebb9cbd — the linter was failing due to pre-existing use of the deprecated reflect.Ptr constant (should be reflect.Pointer) in three files unrelated to my main change: charger/keba-udp.go, server/db/settings/setting.go, and server/influxdb.go.

@jeffborg
Copy link
Copy Markdown
Owner

jeffborg commented May 5, 2026

@copilot undo, I'll merge upstream fix into master

Copy link
Copy Markdown
Author

Copilot AI commented May 5, 2026

@copilot undo, I'll merge upstream fix into master

Done — reverted in e2ac7ba. The three files are back to their original state.

@jeffborg jeffborg marked this pull request as ready for review May 5, 2026 22:38
@jeffborg
Copy link
Copy Markdown
Owner

jeffborg commented May 5, 2026

@copilot merge master will fix lint issue

Merge remote-tracking branch 'origin/master' into copilot/adjust-min-…
418644d 
…slot-time

Co-authored-by: jeffborg <1595430+jeffborg@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented May 5, 2026

@copilot merge master will fix lint issue

Merged master in 418644d — the upstream lint fixes (reflect.Ptr → reflect.Pointer) are now included.

@jeffborg jeffborg merged commit 627400e into master May 5, 2026
12 checks passed
@jeffborg jeffborg deleted the copilot/adjust-min-slot-time branch May 5, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffborg jeffborg jeffborg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeffborg jeffborg

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

set plan min slot to about 3.5-4 minutes from it's current 30

2 participants

@jeffborg