Conversation
ashmaroli
commented
Aug 1, 2018
- Import styles used at jekyllrb.com with a few minor modifications with Flexbox CSS
- Import basic layouts, includes and assets
pathawks
left a comment
There was a problem hiding this comment.
There's a whole lot here that I'm not sure we need/want. It seems like it would be beneficial to only include components in this theme that we know we will be using. (I don't think we're planning to include any tutorials, so I'm not sure what _includes/section_nav_tutorials.html is needed for. I don't think we need to duplicate all the FontAwesome assets.)
For assets that are shared between the primary Jekyll site and this theme, can we just link to the jekyllrb.com assets instead of duplicating them here? Seems like we would have a pretty good chance of hitting browser caches that way.
_config.yml
Outdated
| name: Jekyll Common Theme | ||
| description: Uniform experience across all sites under jekyllrb.com domain | ||
| plugins: | ||
| - jekyll-feed |
There was a problem hiding this comment.
We do not want jekyll-feed, as neither Utterson nor the plugin directory include Posts
Oopsie! That was not meant to be included..
👍 |
ff71167 to
7ef7a6b
Compare