Skip to content

Adapt styles used at jekyllrb.com#2

Open
ashmaroli wants to merge 1 commit intojekyll:masterfrom
ashmaroli:jekyllrb-styles
Open

Adapt styles used at jekyllrb.com#2
ashmaroli wants to merge 1 commit intojekyll:masterfrom
ashmaroli:jekyllrb-styles

Conversation

@ashmaroli
Copy link
Copy Markdown
Member

  • Import styles used at jekyllrb.com with a few minor modifications with Flexbox CSS
  • Import basic layouts, includes and assets

Copy link
Copy Markdown
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a whole lot here that I'm not sure we need/want. It seems like it would be beneficial to only include components in this theme that we know we will be using. (I don't think we're planning to include any tutorials, so I'm not sure what _includes/section_nav_tutorials.html is needed for. I don't think we need to duplicate all the FontAwesome assets.)

For assets that are shared between the primary Jekyll site and this theme, can we just link to the jekyllrb.com assets instead of duplicating them here? Seems like we would have a pretty good chance of hitting browser caches that way.

_config.yml Outdated
name: Jekyll Common Theme
description: Uniform experience across all sites under jekyllrb.com domain
plugins:
- jekyll-feed
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want jekyll-feed, as neither Utterson nor the plugin directory include Posts

@ashmaroli
Copy link
Copy Markdown
Member Author

I'm not sure what _includes/section_nav_tutorials.html is needed for.

Oopsie! That was not meant to be included..

For assets that are shared between the primary Jekyll site and this theme, can we just link to the jekyllrb.com assets instead

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants