Skip to content

Depend on jekyll at least of version 2.5.0 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2015
Merged

Depend on jekyll at least of version 2.5.0 #33

merged 2 commits into from
Nov 27, 2015

Conversation

@exalted
Copy link
Contributor

@exalted exalted commented Nov 27, 2015

Close #28

@exalted
Copy link
Contributor Author

exalted commented Nov 27, 2015

I am not sure how to deal with travis (there are references to JEKYLL_VERSION in there), if/how to “bump up” the jekyll-compose version or update rubygems.org.

/cc @parkr

@parkr
Copy link
Member

parkr commented Nov 27, 2015

I am not sure how to deal with travis

Where it says JEKYLL_VERSION=2.0, make that JEKYLL_VERSION=2.5. Thanks!

@exalted
Copy link
Contributor Author

exalted commented Nov 27, 2015

@parkr apparently it’s ✅

parkr added a commit that referenced this pull request Nov 27, 2015
@parkr
Merge pull request #33 from exalted/update-jekyll-dependency
9f9607b 
Merge pull request 33
@parkr parkr merged commit 9f9607b into jekyll:master Nov 27, 2015
parkr added a commit that referenced this pull request Nov 27, 2015
@parkr
Update history to reflect merge of #33
1d50a47 
[ci skip]
@exalted
Copy link
Contributor Author

exalted commented Nov 27, 2015

🎉🙇

Ali

On Fri, Nov 27, 2015 at 6:34 PM, Parker Moore notifications@github.com
wrote:

Merged #33 #33.

—
Reply to this email directly or view it on GitHub
#33 (comment).

@parkr
Copy link
Member

parkr commented Nov 27, 2015

Thanks for the pull, @exalted!

@exalted
Copy link
Contributor Author

exalted commented Nov 27, 2015

Sure thing! Cheers.

Ali

On Fri, Nov 27, 2015 at 6:42 PM, Parker Moore notifications@github.com
wrote:

Thanks for the pull, @exalted https://github.com/exalted!

—
Reply to this email directly or view it on GitHub
#33 (comment).

@exalted exalted deleted the update-jekyll-dependency branch November 27, 2015 17:43
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@exalted @parkr @jekyllbot