Skip to content

Conversation

@blackjid
Copy link
Contributor

@parkr I know the idea is to use octopress generators, but just for now... while they are ready :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be

type = options["type"] || config["post_type"] || "markdown"

but I don't like having config options just yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right... :) prettier

@blackjid
Copy link
Contributor Author

I fixed the those conditions....
Why you don't want to have options??? maybe if the options are namespaced with the plugin name??

jekyll-compose:
    post_layout: thepost
    post_type: md

@parkr
Copy link
Member

parkr commented Dec 30, 2014

Why you don't want to have options???

Because this project is going to be defunct soon anyway, so it just adds more weight to support. I think choosing sane defaults like md and post work without having customizable defaults for this project. The Octopress project will have better support for this customization, with titles and the like.

@blackjid
Copy link
Contributor Author

Can we change the defaults from 'markdown' to 'md' then?? that's why I really want this to be flexible.
I already use .md and i don't like .markdown

@parkr
Copy link
Member

parkr commented Dec 30, 2014

What's the rationale for that change?

@blackjid
Copy link
Contributor Author

Just because you said

I think choosing sane defaults like md and post work without having customizable defaults for this project.

But the type default is .markdown not .md.

I understand that any of those is ok, I'm just used to use the .md extension in my markdown file.

@blackjid
Copy link
Contributor Author

blackjid commented Jan 2, 2015

if you are not sure, don't worry... we can close de PR...

@parkr
Copy link
Member

parkr commented Jan 2, 2015

Then let's change it to md if you think that's a better default. I'm up for whatever. I think md also makes more sense because that's what GitHub uses when they generate new markdown files.

@blackjid
Copy link
Contributor Author

blackjid commented Jan 8, 2015

great!!
I'll close this PR in favor of #8

@blackjid blackjid closed this Jan 8, 2015
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants