publish command receive the draft path #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/jekyll/commands/publish.rb
Outdated
Member
There was a problem hiding this comment.
can you validate that this exists?
Member
|
👍 in general |
Contributor
Author
|
Hey @parkr I have added a validation. |
lib/jekyll/commands/publish.rb
Outdated
Member
There was a problem hiding this comment.
Can you print the path here? Something like There was no draft found at '#{draft_path}'. Just to be super explicit :D
blackjid
force-pushed
the
publish-with-path
branch
from
4ca2bf6 to
44bc5da
Compare
Contributor
Author
|
I squashed all the commit for a beautiful merge.. :) |
parkr
added a commit
that referenced
this pull request
Dec 30, 2014
parkr
added a commit
that referenced
this pull request
Dec 30, 2014
Contributor
Author
|
hey @parkr thanks!, can you release this please??? |
Member
|
@blackjid we'll release it as soon as we can. I can't offer anymore info than that. 😃 |
Contributor
Author
|
ok, thanks! I can wait :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change a little bit the publish command.
I think it make sense for the
postanddraftcommand to receive the name (title) of the post.. that way you can create the file in the corresponding folder.But for
publishit makes more sense to pass the entire path of the draft you want to publish. This is because this way you can use the autocompletejekyll publish _drafts/my-draft-post.md. I think is easier.