Adding $ to 'iskeyword' breaks PHP

[tommcdo]

Since PHP files can include JavaScript blocks, it seems that this plugin gets invoked for PHP files as well. This plugin runs setlocal iskeyword+=$, which is a good thing for JavaScript; however, in PHP, including $ in 'iskeyword' breaks the expected behaviour of the word text object, as well as things like * and #. In PHP, class members are declared like public $foo, but accessed like $this->foo, so technically $ is not part of the variable name, but more of a variable indicator.

I know this plugin is for JavaScript, but it's nice not to have unexpected side effects. I can't think of a perfect solution to this, unfortunately.

[jelera]

have you tried, deleting setlocal iskeyword+=$, and tested it in a js and/or php file?, If not, would you please?

[tommcdo]

Well, I had tried disabling the plugin entirely; $ is only present in 'iskeyword' when the plugin is enabled.

For good measure, I just now tested deleting this line, and it no longer adds $. I knew that would fix it (and, in fact, I've added setlocal iskeyword-=$ to my ftplugin/php.vim as a temporary solution), but I'm not convinced this is the correct solution in terms of this plugin's purpose: to improve JavaScript syntax support in Vim.

[jelera]

I can't test it right now, so can you try adding this line to your fork of the js syntax file au BufRead,BufNewFile *.php setlocal iskeyword-=$ and remove setlocal iskeyword-=$ from your php.vim. Also, you could try adding that line to your vimrc if it doesn't work.