Add segment skip ability #368
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mcarlton00
left a comment
mcarlton00
left a comment
There was a problem hiding this comment.
Overall very well done. The logging isn't required and this will definitely be merged before the next big release, but it'll be a big help should weirdness ever occur.
Sorry for the delay in reviewing, I had to get segments set up on my server first and was having some trouble with it.
|
|
||
| msgctxt "#30666" | ||
| msgid "Segment Skipper" | ||
| msgstr "Passer les segments" | ||
|
|
||
| msgctxt "#30667" | ||
| msgid "Action to take" | ||
| msgstr "Action" | ||
|
|
||
| msgctxt "#30668" | ||
| msgid "Start Offset (seconds)" | ||
| msgstr "Décalage début de segment (secondes)" | ||
|
|
||
| msgctxt "#30669" | ||
| msgid "End Offset (seconds)" | ||
| msgstr "Décalage fin de segment (secondes)" | ||
|
|
||
| msgctxt "#30670" | ||
| msgid "Intro Skipper" | ||
| msgstr "Introductions" | ||
|
|
||
| msgctxt "#30671" | ||
| msgid "Credit Skipper" | ||
| msgstr "Crédits" | ||
|
|
||
| msgctxt "#30672" | ||
| msgid "Skip" | ||
| msgstr "Passer" | ||
|
|
||
| msgctxt "#30673" | ||
| msgid "Ask" | ||
| msgstr "Passer" | ||
|
|
||
| msgctxt "#30674" | ||
| msgid "Do Nothing" | ||
| msgstr "Ne rien faire" |
There was a problem hiding this comment.
Generally speaking, we only update the translations for the main language (english) through git and handle the rest through https://translate.jellyfin.org/projects/jellycon/jellycon/, but that's not a big deal and we can manage that on the backend this time. Just a heads up for future PRs.
There was a problem hiding this comment.
Alright I did not know that!
I reverted back the changes I made in this file to handle it the proper way.
| log = LazyLogger(__name__) | ||
|
|
||
|
|
||
| class IntroSkipperService(threading.Thread): |
There was a problem hiding this comment.
It would be nice to have a few log statements in these functions for debugging purposes
There was a problem hiding this comment.
I've now added logs on several places. Let me know if you feel like it needs more.
Add logs Add support for recap + preview + commercial
|
I have refactored the code to make it more generic and to make it able to handle previews, recaps and commercials as well to keep it in line with other apps (though I cannot test it because I do not have medias with such segments). Let me know if you have other feedbacks. Edit: I now do have a show with recaps and I can confirm it works well. |
mcarlton00
added
enhancement
2 participants
Hello,
For my personal use I've implemented segment skip ability on jellycon.
This is my first time developping in python (let alone kodi extensions) so I probably did not take the right approach though it runs fine on my shield.
Feel free to make feedbacks.