Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward user_agent config to ffprobe #10448

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Forward user_agent config to ffprobe #10448

merged 2 commits into from
Oct 31, 2023

Conversation

vincent
Copy link

@vincent vincent commented Oct 21, 2023

Changes
Adds the user_agent source config in the ffprobe MediaEncode command.

Issues
ex. Fixes #10175

gaurovgiri

This comment was marked as abuse.

Sign in to view

@vincent
Copy link
Author

vincent commented Oct 24, 2023

I kept the PR as draft because I wanted to ask direction about the test.

I found it difficult to write a proper unit test, partly because MediaEncode methods are private, and it's probably a bad idea to change their visibility just to write tests.

Not sure who to ping. @crobibero ?

@cvium
Copy link
Member

cvium commented Oct 24, 2023

We often change visibility to internal to facilitate testing. Some consider it bad practice, we think of it as being pragmatic.

@vincent vincent marked this pull request as ready for review October 26, 2023 18:09
@Bond-009 Bond-009 merged commit 4962640 into jellyfin:master Oct 31, 2023
18 checks passed
gnattu added a commit to gnattu/jellyfin that referenced this pull request May 27, 2024
@gnattu
Fix ffprobe -user_agent parameter
d07ec4a 
The PR jellyfin#10448 was doing it wrong and actually did not work. Even its unit testing was testing for a wrong output.

Signed-off-by: gnattu <gnattuoc@me.com>
@gnattu gnattu mentioned this pull request May 27, 2024
Merged
jarno9981 added a commit to jarno9981/jellyfin that referenced this pull request Jun 19, 2024
@jarno9981
Squashed commit of the following:
332199c 
commit bf53f1a
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Tue Jun 18 16:16:21 2024 +0200

    Do not override <year> if <releasedate> is set (jellyfin#12120)

commit f2a5ccf
Merge: 2b78980 fcec1fc
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:52:05 2024 +0200

    Merge pull request jellyfin#12065 from Rivenlalala/fix-bdmv-file-extension-case-issue

    Make m2ts extension case-insensitive

commit 2b78980
Merge: a896780 4046ef1
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:38:10 2024 +0200

    Merge pull request jellyfin#12017 from gnattu/overwrite-livetv-codec

    Overwrite supported codecs for livetv

commit a896780
Merge: d813f83 b6595e4
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:37:49 2024 +0200

    Merge pull request jellyfin#12026 from Bond-009/hisubs

    Check hearing impared flags with equality instead of contains

commit d813f83
Merge: 37b7e95 b24d05b
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:37:30 2024 +0200

    Merge pull request jellyfin#12039 from Shadowghost/fix-local-episode-thumb

    Fix local episode image thumb recognition

commit 37b7e95
Merge: 08b64c5 99a04e2
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:36:19 2024 +0200

    Merge pull request jellyfin#12031 from jellyfin/fix-video-embedded-image

    Fix video embedded image detection

commit 08b64c5
Merge: 23a660e ec82023
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:36:05 2024 +0200

    Merge pull request jellyfin#12028 from Shadowghost/fix-replace

    Fix replace all and respect metadata settings

commit 23a660e
Merge: 78eb9b2 7ff3f6a
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:34:44 2024 +0200

    Merge pull request jellyfin#12073 from Shadowghost/fix-mb

    Fix Music Brainz release group query

commit 78eb9b2
Merge: d90f504 8e5a2f5
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:34:31 2024 +0200

    Merge pull request jellyfin#12046 from gnattu/fix-wrong-mpegts-detection

    Fix mpeg-ts detection

commit d90f504
Merge: b25d6d1 b116a27
Author: Bond-009 <bond.009@outlook.com>
Date:   Sat Jun 15 17:34:21 2024 +0200

    Merge pull request jellyfin#12037 from Shadowghost/fix-user-delete

    Do not fail user deletion if we have no playlist folder

commit fcec1fc
Author: Rivenlalala <riven012303@gmail.com>
Date:   Mon Jun 10 13:41:33 2024 +0000

    Make m2ts extension case-insensitive

commit 7ff3f6a
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon Jun 10 21:43:42 2024 +0200

    Fix MB release group query

commit 8e5a2f5
Author: gnattu <gnattuoc@me.com>
Date:   Sun Jun 9 21:23:13 2024 +0800

    Fix mpeg-ts detection

    When the container name is `mpeg`, it means it is MPEG-PS, while the TS container should have the explicit name `mpeg-ts`.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit b24d05b
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sat Jun 8 22:35:50 2024 +0200

    Apply review suggestion

commit fd009fc
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sat Jun 8 21:57:21 2024 +0200

    Simplify metadata subdir check

commit 302eea1
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sat Jun 8 21:51:08 2024 +0200

    Fix local episode image thumb recognition

commit b116a27
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sat Jun 8 16:38:43 2024 +0200

    Do not fail user deletion if we have no playlist folder

commit 99a04e2
Author: nyanmisaka <nst799610810@gmail.com>
Date:   Sat Jun 8 16:55:27 2024 +0800

    Fix video embedded image detection

    Fixes debbfaa. Embedded images also exist in video.

    Signed-off-by: nyanmisaka <nst799610810@gmail.com>

commit ec82023
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Fri Jun 7 23:19:30 2024 +0200

    Respect different metadata settings on refresh

commit e4f3f0b
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Fri Jun 7 23:19:04 2024 +0200

    Remove all data when replacing all

commit b6595e4
Author: Bond_009 <bond.009@outlook.com>
Date:   Fri Jun 7 22:12:35 2024 +0200

    Check hearing impared flags with equality instead of contains

    Fixes jellyfin#12019

commit 4046ef1
Author: gnattu <gnattuoc@me.com>
Date:   Fri Jun 7 17:58:35 2024 +0800

    Overwrite supported codecs for livetv

    Only changeing streamingRequest is not enough. The internal logic will do codec shifting based on supported codecs, need to overwrite all of them.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit b25d6d1
Author: Jellyfin Release Bot <team@jellyfin.org>
Date:   Thu Jun 6 14:41:10 2024 -0400

    Bump version to 10.9.6

commit cf59140
Merge: cc4563a 0359035
Author: Bond-009 <bond.009@outlook.com>
Date:   Thu Jun 6 20:02:38 2024 +0200

    Merge pull request jellyfin#11959 from Shadowghost/continue-validation-if-removed

    Do not stop validation if folder was removed

commit cc4563a
Author: Bond-009 <bond.009@outlook.com>
Date:   Thu Jun 6 16:04:51 2024 +0200

    Use only 1 write connection/DB (jellyfin#11986)

commit 0d984b5
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Thu Jun 6 22:04:33 2024 +0800

    Fix fallback artist when taglib fails (jellyfin#11989)

commit 279cba0
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Thu Jun 6 14:47:15 2024 +0200

    Set ProductionLocations instead of Tags (jellyfin#11984)

commit 2b5d458
Author: Jellyfin Release Bot <team@jellyfin.org>
Date:   Wed Jun 5 18:04:17 2024 -0400

    Bump version to 10.9.5

commit f41efb3
Merge: b78efd6 0155293
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Wed Jun 5 17:49:57 2024 -0400

    Merge pull request jellyfin#11978 from Shadowghost/do-to-fallback-to-media-dir

    Fallback to local dir when saving to media dir fails

commit 0155293
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 23:39:13 2024 +0200

    Fallback to local dir when saving to media dir fails

commit b78efd6
Merge: bfcc09d 8683253
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Wed Jun 5 17:30:56 2024 -0400

    Merge pull request jellyfin#11963 from gnattu/fix-rename-lib

    Fix Library renaming

commit bfcc09d
Merge: a46c17e 918a36d
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Wed Jun 5 17:24:36 2024 -0400

    Merge pull request jellyfin#11921 from Shadowghost/fix-identify-over-nfo

    Fix identify over NFO and replace all when NFO saving enabled

commit a46c17e
Merge: b0bb22b 0f67a5b
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Wed Jun 5 17:09:34 2024 -0400

    Merge pull request jellyfin#11969 from Bond-009/readconns

    Create readonly DB connections when possible

commit b0bb22b
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Wed Jun 5 23:08:12 2024 +0200

    Fix local image saving (jellyfin#11934)

commit 0c03914
Merge: 2a3c904 7cbdb67
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Wed Jun 5 17:01:17 2024 -0400

    Merge pull request jellyfin#11935 from Shadowghost/fix-movie-nfo

    Fix dateadded and movie NFO recognition

commit 2a3c904
Merge: 47c5e0c d7ff6d0
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Wed Jun 5 17:00:31 2024 -0400

    Merge pull request jellyfin#11943 from Shadowghost/increase-migration-batch-size

    Increase lyrics migration batch size to 5000

commit 7cbdb67
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 22:15:51 2024 +0200

    Fix windows test

commit 7058db2
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 20:57:19 2024 +0200

    Fix test

commit 8f7df59
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 19:16:14 2024 +0200

    Do not replace locked fields

commit 0f67a5b
Author: Bond_009 <bond.009@outlook.com>
Date:   Wed Jun 5 10:43:24 2024 +0200

    Actually create readonly connection when asked

commit 19fb00b
Author: Bond_009 <bond.009@outlook.com>
Date:   Wed Jun 5 10:34:43 2024 +0200

    Revert "remove readonly"

    This reverts commit e7016e3.

commit 8683253
Author: gnattu <gnattuoc@me.com>
Date:   Wed Jun 5 08:49:33 2024 +0800

    Fix Library renaming

    This handler should not just spawn a normal library validation task because our new logic will prevent the removal of library root folder unless explicitly required, which will cause the old lib still "ghosting" in the db.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 918a36d
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 01:12:47 2024 +0200

    Fix test

commit 57ae0b5
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 00:58:00 2024 +0200

    Fix typo

commit 262f7dd
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 00:53:09 2024 +0200

    Fix metadata saver check

commit 4714b3a
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed Jun 5 00:26:30 2024 +0200

    Ignore local images when replacing and saving is enabled

commit 0359035
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue Jun 4 23:14:45 2024 +0200

    Do not stop validation if folder was removed

commit b14edb8
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue Jun 4 21:54:04 2024 +0200

    Do not run local providers if replacing and saving is enabled

commit 47c5e0c
Merge: 23b1251 8709d94
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Tue Jun 4 21:33:11 2024 +0200

    Merge pull request jellyfin#11958 from Shadowghost/fix-trailer-nfo-saving

    Export trailer URLs in new format

commit 8709d94
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue Jun 4 19:28:18 2024 +0200

    Export trailer URLs in new format

commit 23b1251
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Tue Jun 4 15:09:20 2024 +0200

    Do not delete file locations for virtual episodes and seasons (jellyfin#11954)

commit 484aea1
Author: cptn <admin@extremehost.club>
Date:   Tue Jun 4 21:05:32 2024 +0800

    NextUp query respects Limit (jellyfin#11956)

commit d1c00ba
Merge: b1a5fe2 2a02abe
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Tue Jun 4 12:48:51 2024 +0200

    Merge pull request jellyfin#11920 from Shadowghost/fix-season-path

    Only set season path if season folder parsing was successful

commit b1a5fe2
Merge: ab43157 3d87885
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Tue Jun 4 12:04:39 2024 +0200

    Merge pull request jellyfin#11933 from Shadowghost/fix-trailer-duplication

    Check trailer distinction by URL

commit d7ff6d0
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon Jun 3 16:39:22 2024 +0200

    Apply review suggestions

commit 253e95d
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon Jun 3 13:53:34 2024 +0200

    Increase lyrics migration fetch batch size to 5000

commit c7ce1aa
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun Jun 2 22:33:02 2024 +0200

    Fix dateadded and movie NFO recognition

commit 3d87885
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun Jun 2 21:31:31 2024 +0200

    Check trailer distinction by URL

commit a7e2271
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun Jun 2 09:17:43 2024 +0200

    Skip local metadata providers when identifying

commit 2a02abe
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun Jun 2 08:59:41 2024 +0200

    Only set season path if season folder parsing was successful

commit ab43157
Author: Jellyfin Release Bot <team@jellyfin.org>
Date:   Sat Jun 1 18:38:59 2024 -0400

    Bump version to 10.9.4

commit 2ddb15c
Merge: 95c7d99 4746c88
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Sat Jun 1 18:33:31 2024 -0400

    Merge pull request jellyfin#11743 from Shadowghost/fix-replace

    Fix replace logic

commit 95c7d99
Merge: e2c909f 402a5e2
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Sat Jun 1 18:32:54 2024 -0400

    Merge pull request jellyfin#11823 from gnattu/env-disable-second-level-cache

    Add Env Var to disable second level cache

commit e2c909f
Merge: a53ea02 7d983ae
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Sat Jun 1 18:32:36 2024 -0400

    Merge pull request jellyfin#11762 from Shadowghost/fix-lyrics

    Mark Audio as RequiresDeserialization and backfill data

commit a53ea02
Merge: 869dab2 a2ab34e
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Sat Jun 1 18:31:55 2024 -0400

    Merge pull request jellyfin#11719 from Shadowghost/fix-season-names

    Move NFO series season name parsing to own local provider

commit 869dab2
Merge: d2be2ee ed1b880
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Sat Jun 1 18:31:31 2024 -0400

    Merge pull request jellyfin#11873 from thornbill/fix-first-time-setup-guest-but-for-real

    Fix FirstTimeSetupHandler allowing public access

commit d2be2ee
Merge: 0392daa bc8ef94
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Sat Jun 1 16:07:05 2024 -0400

    Merge pull request jellyfin#11910 from Bond-009/audionormout

    Audio normalization: parse ffmpeg output line by line

commit bc8ef94
Author: Bond_009 <bond.009@outlook.com>
Date:   Sat Jun 1 17:50:12 2024 +0200

    Audio normalization: parse ffmpeg output line by line

    Should prevent OOM error
    Also optimized the regex so it can bail out earlier

commit ed1b880
Author: Bill Thornton <billt2006@gmail.com>
Date:   Fri May 31 16:31:15 2024 -0400

    Remove api key check and simplify conditions

commit 7221e7c
Author: Bill Thornton <billt2006@gmail.com>
Date:   Fri May 31 14:09:04 2024 -0400

    Fix FirstTimeSetupHandler failing for users and update tests

commit 0392daa
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Fri May 31 21:01:47 2024 +0800

    Relax remuxing requirement for LiveTV (jellyfin#11851)

commit d602b6d
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Fri May 31 21:01:28 2024 +0800

    Fix multi-part album folder being detected as artist folder (jellyfin#11886)

commit b8a0cf6
Merge: 26419c6 97d7151
Author: Cody Robibero <cody@robibe.ro>
Date:   Fri May 31 07:00:56 2024 -0600

    Merge pull request jellyfin#11859 from gnattu/use-ffprobe-audio-metadata-fallback

commit 26419c6
Merge: 8e979bd cfe67ff
Author: Cody Robibero <cody@robibe.ro>
Date:   Fri May 31 06:58:00 2024 -0600

    Merge pull request jellyfin#11894 from gnattu/escape-concated-path

commit a71e2d9
Author: Bill Thornton <thornbill@users.noreply.github.com>
Date:   Fri May 31 03:18:33 2024 -0400

    Update FirstTimeSetupHandler.cs

    Co-authored-by: Claus Vium <cvium@users.noreply.github.com>

commit cfe67ff
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Fri May 31 15:14:29 2024 +0800

    Add extra white space

    Co-authored-by: Claus Vium <cvium@users.noreply.github.com>

commit 78e3ee1
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Fri May 31 14:59:57 2024 +0800

    Don't use interpolated strings

    Co-authored-by: Claus Vium <cvium@users.noreply.github.com>

commit 2cb74e3
Author: gnattu <gnattuoc@me.com>
Date:   Fri May 31 14:54:00 2024 +0800

    Escape tmpConcatPath for DVD and BD folder

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 8e979bd
Merge: ae584be e099fd6
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Thu May 30 19:52:20 2024 -0400

    Merge pull request jellyfin#11882 from Shadowghost/fix-season-missing-episode

    Fix missing episodes query for seasons

commit e099fd6
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 30 20:26:26 2024 +0200

    Fix missing episodes query for seasons

commit 35962bc
Author: Bill Thornton <billt2006@gmail.com>
Date:   Thu May 30 12:08:52 2024 -0400

    Fix FirstTimeSetupHandler api key test

commit ae584be
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Thu May 30 17:32:37 2024 +0200

    Return missing episodes for series when no user defined (jellyfin#11806)

commit 5630337
Merge: f8c7f36 8db79c0
Author: Cody Robibero <cody@robibe.ro>
Date:   Thu May 30 09:32:00 2024 -0600

    Merge pull request jellyfin#11876 from Bond-009/enableLib

commit f8c7f36
Merge: d0336cd cfab4eb
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Thu May 30 10:36:30 2024 -0400

    Merge pull request jellyfin#11867 from Shadowghost/stable-dep-upgrade

    Upgrade dependencies

commit 4746c88
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 30 09:21:23 2024 +0200

    Apply review suggestion

commit b7d6bed
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 30 08:54:44 2024 +0200

    Apply review suggestion

commit 8db79c0
Author: Bond_009 <bond.009@outlook.com>
Date:   Wed May 29 22:27:29 2024 +0200

    Don't check if admin has access to library when updating

    The access check also checks if the library is enabled, this makes it impossible to enable disabled libraries.
    Regression from  jellyfin#11171

commit 8fa7ff6
Author: Bill Thornton <billt2006@gmail.com>
Date:   Wed May 29 14:35:41 2024 -0400

    Defer standard authentication checks to DefaultAuthorizationHandler

commit d0336cd
Merge: 730b01f d07ec4a
Author: Bond-009 <bond.009@outlook.com>
Date:   Wed May 29 10:00:36 2024 +0200

    Merge pull request jellyfin#11857 from gnattu/fix-ffprobe-useragent

    Fix ffprobe -user_agent parameter

commit cfab4eb
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue May 28 21:42:42 2024 +0200

    Fix xUnit

commit 5f1c500
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue May 28 21:33:03 2024 +0200

    Upgrade dependencies

commit 97d7151
Author: gnattu <gnattuoc@me.com>
Date:   Tue May 28 20:24:40 2024 +0800

    Don't use finally block for tag fallback

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 475fa36
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Tue May 28 20:23:03 2024 +0800

    Use better exception logging

    Co-authored-by: Claus Vium <cvium@users.noreply.github.com>

commit e8d1ee0
Author: gnattu <gnattuoc@me.com>
Date:   Tue May 28 14:24:36 2024 +0800

    Use music metadata from ffprobe when TagLib fails

    TagLib has its own limitations, which cause it to fail on certain audio files or extract incomplete information from the tags. Use the information from ffprobe when TagLib fails to extract data.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit d07ec4a
Author: gnattu <gnattuoc@me.com>
Date:   Tue May 28 03:18:46 2024 +0800

    Fix ffprobe -user_agent parameter

    The PR jellyfin#10448 was doing it wrong and actually did not work. Even its unit testing was testing for a wrong output.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 684dfed
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon May 27 19:14:17 2024 +0200

    Do not remove already set people on locked items

commit 730b01f
Author: Jellyfin Release Bot <team@jellyfin.org>
Date:   Sun May 26 20:00:29 2024 -0400

    Bump version to 10.9.3

commit 45e8872
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Mon May 27 01:40:28 2024 +0800

    Extract media attachment one by one if the filename appears to be a path (jellyfin#11812)

commit cc2c00d
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun May 26 17:01:19 2024 +0200

    Respect locked fields when updating children from parent

commit 402a5e2
Author: gnattu <gnattuoc@me.com>
Date:   Sun May 26 10:45:38 2024 +0800

    Use simpler config value

    Only true and false are supported now

    Signed-off-by: gnattu <gnattuoc@me.com>

commit bcf884c
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Sat May 25 11:55:48 2024 -0400

    Update GitHub workflows from Master

    Backport fixes from:
     - jellyfin#11780
     - jellyfin#11779
     - jellyfin#11769
     - jellyfin#11733
     - jellyfin#11515

commit 2eece01
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Sat May 25 23:44:03 2024 +0800

    Filter invalid IPs on external interface matching (jellyfin#11766)

commit ef98589
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Sat May 25 23:43:53 2024 +0800

    Use SharedStream for LiveTV more restrictively (jellyfin#11805)

commit 5e75142
Author: Nyanmisaka <nst799610810@gmail.com>
Date:   Sat May 25 23:00:30 2024 +0800

    Fix the IOSurf error in QSV transcoding (jellyfin#11830)

commit b9c0fc6
Author: gnattu <gnattuoc@me.com>
Date:   Sat May 25 01:12:00 2024 +0800

    Add Env Var to disable second level cache

    This is an attempt to track down possible causes of remaining database lockups. Add an environment variable to disable the second-level cache entirely to see if it works better on systems that still experience lockups.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 4a344be
Author: NotSaifA <69015839+NotSaifA@users.noreply.github.com>
Date:   Fri May 24 09:50:55 2024 -0400

    Trickplay: kill ffmpeg when task is cancelled (jellyfin#11790)

commit b2d54b8
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Fri May 24 15:50:09 2024 +0200

    Improve reliability of HasChanged check (jellyfin#11792)

commit e7b1162
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Fri May 24 21:36:59 2024 +0800

    Force more compatible transcoding profile for LiveTV (jellyfin#11801)

commit d89e5a0
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Fri May 24 15:36:39 2024 +0200

    Exclude virtual items from DateLastMediaAdded calculation (jellyfin#11804)

commit 4a54e5d
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Fri May 24 15:36:19 2024 +0200

    Add Canceled to ended state (jellyfin#11808)

commit d9232e0
Merge: 52be8be 952995f
Author: Bond-009 <bond.009@outlook.com>
Date:   Fri May 24 14:19:37 2024 +0200

    Merge pull request jellyfin#11798 from gnattu/fix-trickplay-image-height

    Recalculate trickplay image height for anamorphic videos

commit 52be8be
Merge: ab6c242 77abafc
Author: Bond-009 <bond.009@outlook.com>
Date:   Fri May 24 14:18:10 2024 +0200

    Merge pull request jellyfin#11754 from Shadowghost/fix-bd-chapter-images

    Fix BD/DVD folder chapter image extraction

commit ab6c242
Merge: eb437e7 d5e29bf
Author: Bond-009 <bond.009@outlook.com>
Date:   Fri May 24 14:17:59 2024 +0200

    Merge pull request jellyfin#11802 from crobibero/nullable-match-term

    Mark SearchHint.MatchedTerm as nullable

commit eb437e7
Merge: 2ddf2a7 ab36c4c
Author: Bond-009 <bond.009@outlook.com>
Date:   Fri May 24 14:17:51 2024 +0200

    Merge pull request jellyfin#11799 from nyanmisaka/fix-va-vk-interop-chk

    Disable VA-VK interop on not supported kernel versions

commit 2ddf2a7
Merge: 60232ce 6777f47
Author: Bond-009 <bond.009@outlook.com>
Date:   Fri May 24 14:16:45 2024 +0200

    Merge pull request jellyfin#11781 from Bond-009/orderts

    Retain order blu-ray segments

commit 60232ce
Merge: 06a5ddd fa2bff3
Author: Bond-009 <bond.009@outlook.com>
Date:   Fri May 24 14:16:33 2024 +0200

    Merge pull request jellyfin#11788 from gnattu/override-too-small-trickplay-image-interval

    Override too small trickplay image interval

commit 952995f
Author: gnattu <gnattuoc@me.com>
Date:   Thu May 23 23:08:29 2024 +0800

    Ignore NullOrEmpty imageStream.AspectRatio

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 933a285
Author: gnattu <gnattuoc@me.com>
Date:   Thu May 23 23:03:35 2024 +0800

    Use single quote

    Signed-off-by: gnattu <gnattuoc@me.com>

commit f8da69f
Author: gnattu <gnattuoc@me.com>
Date:   Thu May 23 23:02:57 2024 +0800

    Allow decimal aspect ratio

    Signed-off-by: gnattu <gnattuoc@me.com>

commit d5e29bf
Author: Cody Robibero <cody@robibe.ro>
Date:   Thu May 23 07:16:56 2024 -0600

    here you go Niels

commit ab36c4c
Author: nyanmisaka <nst799610810@gmail.com>
Date:   Thu May 23 14:53:00 2024 +0800

    Disable VA-VK interop on not supported kernel versions

    Signed-off-by: nyanmisaka <nst799610810@gmail.com>

commit c6e2964
Author: gnattu <gnattuoc@me.com>
Date:   Wed May 8 08:33:23 2024 +0800

    Recalculate trickplay image height for anamorphic videos

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 95a6291
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed May 22 19:26:19 2024 +0200

    Fixes

commit fa2bff3
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Wed May 22 21:17:00 2024 +0800

    Explicitly use decimal

    Co-authored-by: Cody Robibero <cody@robibe.ro>

commit 58041e1
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed May 22 13:44:45 2024 +0200

    Fix backwards merge

commit 447f73c
Author: gnattu <gnattuoc@me.com>
Date:   Wed May 22 13:41:54 2024 +0800

    Fix bitrate calculation accuracy

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 9145be6
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed May 22 07:38:53 2024 +0200

    Remove local metadata stop logic

commit 8612958
Author: gnattu <gnattuoc@me.com>
Date:   Wed May 22 13:35:28 2024 +0800

    Override too small trickplay image interval

    Some users may set this value too low, causing the trickplay generation to fail. Reset this interval to the minimum valid value of 1 second when the user-configured value is too small to prevent generation failures.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit f5a8fca
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue May 21 23:22:44 2024 +0200

    Don't drop existing metadata if item gets local locked

commit 2a61261
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue May 21 23:08:30 2024 +0200

    Extend minimum local metadata requirements

commit 0b64426
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue May 21 23:08:00 2024 +0200

    Fix local locked and StopRefreshIfLocalMetadataFound logic

commit f3bf9bc
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue May 21 21:47:29 2024 +0200

    Fix final merge logic

commit 06a5ddd
Merge: d608f1e cf04e1d
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Tue May 21 21:40:22 2024 +0200

    Merge pull request jellyfin#11774 from Bond-009/downmix

    Apply audio boost when downmixing regardless of downmixalgo

commit 8a5a93e
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Tue May 21 21:14:30 2024 +0200

    Allow removal of all people from an item

commit 6777f47
Author: Bond_009 <bond.009@outlook.com>
Date:   Tue May 21 20:19:15 2024 +0200

    Retain order blu-ray segments

commit cf04e1d
Author: Bond_009 <bond.009@outlook.com>
Date:   Tue May 21 15:54:59 2024 +0200

    Apply audio boost when downmixing regardless of downmixalgo

    This is what I'd expect from the naming
    Should fix jellyfin#11771

commit d608f1e
Merge: 86f5c93 53de8c0
Author: Bond-009 <bond.009@outlook.com>
Date:   Tue May 21 13:58:01 2024 +0200

    Merge pull request jellyfin#11713 from gnattu/fix-vt-h264-profile

    Fix VideoToolbox H264 constrained profile option

commit 86f5c93
Merge: 4fcbeef 2cebd5e
Author: Bond-009 <bond.009@outlook.com>
Date:   Tue May 21 13:57:41 2024 +0200

    Merge pull request jellyfin#11739 from Shadowghost/fix-trickplay

    Do not run trickplay on scan if disabled

commit 4fcbeef
Merge: 76854b5 b19b346
Author: Bond-009 <bond.009@outlook.com>
Date:   Tue May 21 13:57:31 2024 +0200

    Merge pull request jellyfin#11738 from crobibero/non-user-session

    Don't require user when getting current session

commit 7d983ae
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon May 20 22:51:38 2024 +0200

    Mark Audio as RequiresDeserialization and backfill data

commit a2ab34e
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon May 20 20:12:52 2024 +0200

    Rename provider to be run after normal season NFO provider

commit 77abafc
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon May 20 13:19:05 2024 +0200

    Fix BD/DVD folder chapter image extraction

commit e67eb48
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon May 20 12:49:26 2024 +0200

    Never revert locked state

commit 37d7e8f
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon May 20 12:24:57 2024 +0200

    Fix replacement logic

commit e6eef8b
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Mon May 20 01:45:12 2024 +0200

    Set path for season folders

commit 52cfd9f
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun May 19 19:59:47 2024 +0200

    Properly pass replace flag to remote provider logic

commit 9a9e8e2
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun May 19 18:36:18 2024 +0200

    Prevent infite loop

commit 2cebd5e
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun May 19 16:52:59 2024 +0200

    Do not run trickplay on scan if disabled

commit 7fa7226
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sun May 19 16:50:51 2024 +0200

    Only set season name if it's unset

commit b19b346
Author: Cody Robibero <cody@robibe.ro>
Date:   Sun May 19 08:25:38 2024 -0600

    Don't require user when getting current session

commit 99de0ca
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sat May 18 21:28:07 2024 +0200

    Directly use ParentId

commit c106b39
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sat May 18 20:41:04 2024 +0200

    Apply review suggestion

commit c274062
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Sat May 18 20:19:12 2024 +0200

    Move NFO series season name parsing to own local provider

commit 53de8c0
Author: gnattu <gnattuoc@me.com>
Date:   Sat May 18 19:53:23 2024 +0800

    Fix VideoToolbox H264 constrained profile option

    Like a lot of other encoders they need an underscore between two words.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 76854b5
Author: Jellyfin Release Bot <team@jellyfin.org>
Date:   Fri May 17 16:09:34 2024 -0400

    Bump version to 10.9.2

commit 5200633
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Fri May 17 20:13:49 2024 +0200

    Prevent double iterating over all seasons (jellyfin#11700)

commit 832e27a
Merge: 2da06bc 18e6c1e
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Fri May 17 13:47:47 2024 -0400

    Merge pull request jellyfin#11680 from Shadowghost/secure-local-playlists

    Secure local playlist path handling

commit 2da06bc
Merge: 46c748d dc93cc1
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Fri May 17 13:47:24 2024 -0400

    Merge pull request jellyfin#11647 from Shadowghost/fix-season-names

    Fix season names

commit 46c748d
Merge: 430d450 c647143
Author: Joshua M. Boniface <joshua@boniface.me>
Date:   Fri May 17 13:47:12 2024 -0400

    Merge pull request jellyfin#11699 from cvium/fix_livetv

    Use MediaType instead of ToString and add text/ as disallowed mimetypes

commit 430d450
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Fri May 17 18:57:18 2024 +0200

    Fix network binding (jellyfin#11671)

    * Fix network binding

    * Better log output

    * Fix Kestrel bind message

commit 0293787
Merge: d303ca5 dec2032
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Fri May 17 18:55:01 2024 +0200

    Merge pull request jellyfin#11689 from gnattu/workaround-ffmpeg-seek

    Workaround ffmpeg keyframe seeking for external subtitles

commit d303ca5
Merge: 26714e2 dd0ab8e
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Fri May 17 18:54:32 2024 +0200

    Merge pull request jellyfin#11698 from Bond-009/issue11605

    Fix not binding to SQL parameters

commit c647143
Author: cvium <clausvium@gmail.com>
Date:   Fri May 17 18:50:44 2024 +0200

    fix(livetv): use MediaType instead of ToString and add text/ as disallowed mimetypes

commit dd0ab8e
Author: Bond_009 <bond.009@outlook.com>
Date:   Fri May 17 18:35:11 2024 +0200

    Fix not binding to SQL parameters

    Whitespace values weren't being filtered out in advance
    Remove the posibility of this happening again by always binding

    Should fix jellyfin#11605

commit 18e6c1e
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Fri May 17 10:58:00 2024 +0200

    Apply review comments

commit dec2032
Author: gnattu <gnattuoc@me.com>
Date:   Fri May 17 12:12:45 2024 +0800

    Workaround ffmpeg keyframe seeking for external subtitles

    We seek to the exact position of the keyframe for direct stream/remuxing, but FFmpeg seeks to the previous keyframe when the exact time is provided as input. To work around this, add a 0.5 second offset to the seeking time.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 287e06d
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 16 21:55:00 2024 +0200

    If itemPath exists, use that, otherwise try getting full path from relative path

commit dc93cc1
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 16 19:36:49 2024 +0200

    Apply review suggestion

commit 26714e2
Merge: c6c48a2 15489ee
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Thu May 16 19:07:17 2024 +0200

    Merge pull request jellyfin#11673 from Shadowghost/fix-local-playlists

    Fix local playlist scanning

commit c6c48a2
Author: Tim Eisele <Shadowghost@users.noreply.github.com>
Date:   Thu May 16 19:06:11 2024 +0200

    Fix series status parsing (jellyfin#11648)

    * Fix series status parsing

    * Apply review suggestions and add test

    * Apply review suggestion

    * Apply review suggestions

commit f8b67ec
Merge: ddd5c30 0756174
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Thu May 16 19:05:00 2024 +0200

    Merge pull request jellyfin#11670 from jellyfin/attempt-restore-user-cache

    Restore caching for UserManager

commit ddd5c30
Merge: 9b98638 9b65d24
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Thu May 16 19:04:34 2024 +0200

    Merge pull request jellyfin#11675 from gnattu/fix-vaapi-mjpeg-parameter

    Fix quality parameter for vaapi_mjpeg

commit 9b98638
Merge: 8aee500 c45dd5d
Author: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Date:   Thu May 16 19:02:52 2024 +0200

    Merge pull request jellyfin#11677 from Bond-009/migrateuserdb

     Properly dispose dbContext in MigrateUserDb

commit 2ca8ce6
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 16 17:04:42 2024 +0200

    Apply review suggestions

commit 56a158e
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 16 16:10:37 2024 +0200

    Secure local playlist path handling

commit 9b65d24
Author: gnattu <gnattuoc@me.com>
Date:   Thu May 16 20:18:36 2024 +0800

    Use OrdinalIgnoreCase comparison

    Signed-off-by: gnattu <gnattuoc@me.com>

commit c45dd5d
Author: Bond_009 <bond.009@outlook.com>
Date:   Thu May 16 10:58:32 2024 +0200

    Properly dispose dbContext in MigrateUserDb

commit af4b732
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 16 08:25:35 2024 +0200

    Fix override of locked name

commit 1cdf0f5
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 16 08:22:40 2024 +0200

    Apply review suggestion

commit 20a1da1
Author: gnattu <gnattuoc@me.com>
Date:   Thu May 16 11:49:41 2024 +0800

    fix quality parameter for vaapi

    Hardware encoders has different expectations about quality input. VAAPI's mjpeg encoder excepts JPEG quality divided by QP2LAMBDA as input.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 8aee500
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Thu May 16 07:27:25 2024 +0800

    Always fallback for failed HEAD request (jellyfin#11668)

commit c161541
Author: Bond-009 <bond.009@outlook.com>
Date:   Thu May 16 01:26:42 2024 +0200

    Don't generate TrickPlay images for files that don't exist (jellyfin#11653)

commit 15489ee
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Thu May 16 00:31:50 2024 +0200

    Fix album photos

commit 80c9589
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed May 15 23:20:14 2024 +0200

    Fix local playlist scanning

commit a5d60c4
Author: Cody Robibero <cody@robibe.ro>
Date:   Wed May 15 07:06:29 2024 -0600

    Allow empty user id when getting device list (jellyfin#11633)

commit 2cb052a
Author: Bill Thornton <thornbill@users.noreply.github.com>
Date:   Wed May 15 09:06:10 2024 -0400

    Fix FirstTimeSetupPolicy allowing guest access (jellyfin#11651)

commit 0756174
Author: gnattu <gnattuoc@me.com>
Date:   Wed May 15 12:43:46 2024 +0800

    Restore caching for UserManager.cs

    It seems like the EFCore's second level cache does not really work, and we are having very heavy database query here.

    Signed-off-by: gnattu <gnattuoc@me.com>

commit 3f760e6
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Wed May 15 11:28:39 2024 +0800

    Fix missing filename for timer (jellyfin#11629)

commit d5dc443
Author: Nathan McCrina <nathan.mccrina@outlook.com>
Date:   Tue May 14 22:28:29 2024 -0500

    Handle exception for unexpected audio file YEAR tag values (jellyfin#11621)

commit 4822843
Author: Shadowghost <Ghost_of_Stone@web.de>
Date:   Wed May 15 01:23:23 2024 +0200

    Fix season names

commit f396a95
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Mon May 13 21:20:47 2024 +0800

    Fix network config (jellyfin#11587)

commit 717afcd
Author: Jellyfin Release Bot <team@jellyfin.org>
Date:   Sun May 12 20:10:24 2024 -0400

    Bump version to 10.9.1

commit 25c50bc
Author: Tim Gels <43609220+TimGels@users.noreply.github.com>
Date:   Sun May 12 23:19:02 2024 +0200

    Change "try" to "attempt" english translation (jellyfin#11578)

commit f77a5d0
Author: Cody Robibero <cody@robibe.ro>
Date:   Sun May 12 15:18:56 2024 -0600

    Default to processor count concurrent scan instead of 2 * processor count (jellyfin#11569)

commit 6689d83
Author: gnattu <gnattu@users.noreply.github.com>
Date:   Mon May 13 05:12:07 2024 +0800

    Fix absolute path checking on windows (jellyfin#11570)

commit c190735
Author: Cody Robibero <cody@robibe.ro>
Date:   Sun May 12 09:14:36 2024 -0600

    Add metrics collector to disposable parts (jellyfin#11539)

commit efba619
Author: Cody Robibero <cody@robibe.ro>
Date:   Sun May 12 09:14:26 2024 -0600

    Fix migration with special Rating (jellyfin#11541)

commit 7d27154
Author: Cody Robibero <cody@robibe.ro>
Date:   Sat May 11 15:12:14 2024 -0600

    Disable nuget warning in Jellyfin.Extensions

commit 327f92b
Author: Jellyfin Release Bot <team@jellyfin.org>
Date:   Sat May 11 14:23:58 2024 -0400

    Bump version to 10.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1337joe 1337joe 1337joe approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

@crobibero crobibero crobibero approved these changes

@gaurovgiri gaurovgiri gaurovgiri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue]: Call to ffprobe not passing user_agent parameter
6 participants
@vincent @cvium @1337joe @Bond-009 @crobibero @gaurovgiri