ci: build docs on PRs to gate deploy-time regressions#7
Merged
Conversation
The check job ran astro check + eslint + prettier but never built. A dependency bump that breaks `astro build` (e.g. a Starlight/Astro minor) passed CI and only failed in deploy.yml on push to main, after merge. Build both workspaces in the same check job so green CI means the site actually builds before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The required
checkjob runsastro check+ eslint + prettier but never builds the site. The build only runs indeploy.ymlon push tomain— after merge. So a dependency bump that breaksastro build(the exact failure class that hit jellyrock.app#22's Astro minor) passes docs CI and only blows up post-merge on the VPS deploy.Change
Run
npm run build(user-docs + dev-docs) in the samecheckjob, after the existing checks. The required-check context stayscheck, so no branch-protection config change is needed.Verified locally against current
main: both workspaces build (17 pages). This makes "green CI" mean the site actually builds, which is the precondition for trusting dependency auto-merge in this repo (see ADR-0004 in command-center).