fix(ci): prevent grep pipe from failing the diagnostics step#2170
Merged
gounthar merged 1 commit intojenkins-docs:mainfrom Apr 21, 2026
Merged
Conversation
grep exits 1 when no match is found. Under bash -e with pipefail, this would abort the failure-capture step before it finishes, defeating its purpose. Use grep -m1 with || true to ensure the step always succeeds. Signed-off-by: Bruno Verachten <gounthar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The failure-diagnostics step added in #2169 had a subtle bug:
grep controller | head -1exits 1 when no matching container is found. Under bash's-e+pipefail, this aborts the step before it can print any output — the opposite of what the step is meant to do.Changes
.github/workflows/plugin_update.yml: Replacegrep controller | head -1withgrep -m1 controller || truein theCapture Jenkins logs on failurestep so the step never fails due to missing containers.Why it matters
This was reported on PR #2169 by the automated code reviewer. The
if: failure()guard ensures the step only runs when something is already broken — having the diagnostic step itself fail silently would hide the root cause of the original failure.