fix(jcasc): remove deprecated excludeClientIPFromCrumb + silence release-drafter#2183
Merged
Merged
Conversation
DefaultCrumbIssuer no longer supports excludeClientIPFromCrumb in
newer Jenkins/JCasc versions, causing a fatal UnknownAttributesException
at startup. Replace with empty standard: {} block.
Also add a failure capture step in plugin_update.yml to surface Jenkins
logs when the workflow fails, improving diagnosability.
Signed-off-by: Bruno Verachten <gounthar@gmail.com>
Same fix as applied to main: replace push/pull_request triggers with workflow_dispatch to stop the action failing on every event due to the zero-releases pagination bug in release-drafter. Signed-off-by: Bruno Verachten <gounthar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes backported from
mainto theweeklybranch.Changes
1. JCasc startup crash (
dockerfiles/jenkins.yaml)DefaultCrumbIssuerno longer accepts theexcludeClientIPFromCrumbattribute in newer Jenkins/JCasc versions. The baked-in config caused a fatalUnknownAttributesExceptionat startup, putting the controller into a restart loop.Note: the
plugins.txtversion bumps from themainfix are not included — theweeklybranch usescoverage:2.xwhich does not have the plugin dependency conflict.2. Failure diagnostics step (
.github/workflows/plugin_update.yml)Adds a
Capture Jenkins logs on failurestep so controller logs are surfaced in CI when the workflow fails. Usesgrep -m1 controller || trueto avoid aborting the step under bash-e/pipefailwhen no container is found.3. Release Drafter silenced (
.github/workflows/release-drafter.yml)The action fails on every push and PR event because the repo has no releases, hitting a known pagination bug in
release-drafter. Triggers replaced withworkflow_dispatchonly.