Create a global CONTRIBUTING page for repositories which do not override it#24
Merged
oleg-nenashev merged 3 commits intomasterfrom Dec 2, 2019
Merged
Create a global CONTRIBUTING page for repositories which do not override it#24oleg-nenashev merged 3 commits intomasterfrom
oleg-nenashev merged 3 commits intomasterfrom
Conversation
oleg-nenashev
requested review from
MarkEWaite,
markjacksonfishing and
tracymiranda
MarkEWaite
approved these changes
Nov 28, 2019
halkeye
approved these changes
Nov 28, 2019
Member
|
same file for infra too? |
Member
Author
@halkeye Already there: https://github.com/jenkins-infra/.github/blob/master/CONTRIBUTING.md |
daniel-beck
approved these changes
Nov 28, 2019
markjacksonfishing
approved these changes
Nov 30, 2019
daniel-beck
reviewed
Nov 30, 2019
Member
Author
|
Now it's a NOTE @daniel-beck |
Member
|
I think even WARNING was fine -- I suspect it's the table formatting using a TH instead of TR, and it's bold by default? Anyway, detail 🤷♂ |
jetersen
approved these changes
Dec 1, 2019
res0nance
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of the global Contributing page for those repositories which do not have it