fix subdirectory validation

[ydubreuil]

Current implementation doesn't work when builds are running on a slave node: code is checking that slave directory exists on master node, not on slave node. This patch fixes this and enhance logs to help diagnose further issues if any.

@reviewbybees

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[varmenise]

Can isSubDirectory(basePath, sourcePath)) ever be false? Since we said FilePath sourcePath = basePath.withSuffix(subdirectory).absolutize();

[ydubreuil]

Yes, it could be false if subdirectory contains something like "../non-workspace-dir". I guess that's what the original author wanted to check.

[varmenise]

🐝

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be
reviewed by other CloudBees employees before we seek to have the change accepted. If you want to find out
more about our process please see this note

[ydubreuil]

@reviewbybees done

[ghost]

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

[JohnBloom]

Any luck that this will get merged in? We are waiting for it upstream and feeling the pain. awslabs#28

[ydubreuil]

@Suryanarayanan Would you mind merging this PR? Thanks

[JohnBloom]

Does this build the plugin or does another PR need to be made to the awslabs project?

[surybala]

I did create another PR and merged into parent awslabs repo.

[JohnBloom]

Thanks a ton!