Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@uhafner
Copy link
Member

@uhafner uhafner commented Jun 30, 2022

Otherwise the Fraction class will produce an overflow and throws an ArithmeticException.

@uhafner uhafner added the bug Bugs or performance problems label Jun 30, 2022
@uhafner uhafner linked an issue Jun 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #415 (ad2fcf1) into master (02ba219) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #415      +/-   ##
============================================
+ Coverage     71.45%   71.60%   +0.14%     
- Complexity      980      984       +4     
============================================
  Files            86       87       +1     
  Lines          3713     3722       +9     
  Branches        436      436              
============================================
+ Hits           2653     2665      +12     
+ Misses          914      911       -3     
  Partials        146      146              
Impacted Files Coverage Δ
...o/jenkins/plugins/coverage/model/CoverageNode.java 94.34% <100.00%> (+1.18%) ⬆️
...ins/plugins/coverage/model/CoveragePercentage.java 86.48% <100.00%> (+0.37%) ⬆️
...o/jenkins/plugins/coverage/model/SafeFraction.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ba219...ad2fcf1. Read the comment docs.

…ing calculations with `Fraction` instances.
@uhafner uhafner merged commit 68867a2 into master Jun 30, 2022
@uhafner uhafner deleted the delta-overflow branch June 30, 2022 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bugs or performance problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArithmeticException when computing the delta coverage

2 participants