Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@medianick
Copy link
Contributor

@medianick medianick commented Jul 2, 2022

Allows for this report adapter to be disambiguated from the one provided by the Cobertura plugin in the case both plugins are installed; see https://stackoverflow.com/a/72839475/466874 for this specific case and https://issues.jenkins.io/browse/INFRA-2012 and jenkins-infra/helpdesk#1662 for the fundamental issue.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Allows for this report adapter to be disambiguated from the one provided by the Cobertura plugin in the case both are installed; see https://stackoverflow.com/a/72839475/466874 for this specific case and https://issues.jenkins.io/browse/INFRA-2012 and jenkins-infra/helpdesk#1662 for the fundamental issue.
@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #417 (a73506f) into master (79b751f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #417   +/-   ##
=========================================
  Coverage     72.08%   72.08%           
  Complexity      984      984           
=========================================
  Files            86       86           
  Lines          3694     3694           
  Branches        431      431           
=========================================
  Hits           2663     2663           
  Misses          885      885           
  Partials        146      146           
Impacted Files Coverage Δ
...ugins/coverage/adapter/CoberturaReportAdapter.java 58.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b751f...a73506f. Read the comment docs.

@uhafner uhafner added the bug Bugs or performance problems label Jul 2, 2022
@uhafner
Copy link
Member

uhafner commented Jul 2, 2022

Thanks for fixing that. I totally forgot that the old cobertura plugin still is used.

@uhafner uhafner merged commit f2906b8 into jenkinsci:master Jul 2, 2022
@medianick
Copy link
Contributor Author

Thanks for fixing that. I totally forgot that the old cobertura plugin still is used.

Thanks for merging it! This will give us a smoother path toward removing the Cobertura plugin since we'll be able to switch to the new coberturaReportAdapter adapter symbol for our existing jobs first, then remove the plugin, then (if desired) switch to the cobertura adapter symbol without conflict/error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bugs or performance problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants