Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Fix NPE when line number is not present in model #428

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Fix NPE when line number is not present in model #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/src/main/java/io/jenkins/plugins/coverage/targets/CoverageResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ public void addAdditionalProperty(final String propertyName, final String value)
}

public Set<String> getAdditionalProperty(final String propertyName) {
return additionalProperties.get(propertyName);
return additionalProperties.getOrDefault(propertyName, Collections.emptySet());
}

/**
Expand Down
7 changes: 7 additions & 0 deletions plugin/src/test/java/io/jenkins/plugins/coverage/model/CoverageResultTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ class CoverageResultTest extends AbstractCoverageTest {
private static final CoverageElement SOURCE_FILE = CoverageElement.FILE;
private static final CoverageElement CLASS_NAME = JavaCoverageReportAdapterDescriptor.CLASS;

@Test
void shouldNeverReturnNullForSets() throws CoverageException {
CoverageResult project = readReport("jacoco-codingstyle.xml");

assertThat(project.getAdditionalProperty("not-found")).isEmpty();
}

@Test
void shouldReadJaCoCoResult() throws CoverageException {
CoverageResult project = readReport("jacoco-codingstyle.xml");
Expand Down