Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@y-higuchi
Copy link
Contributor

Use buffered reads when recovering coverage result.

After we started using this plugin,
we noticed fairly large number of 1 byte reads hitting NFS server hurting performance.

1 byte reads seems to be coming from PeekInputStream calls used inside ObjectInputStream
directly hitting FileInputStream.

This PR attempts to mitigate the issue by inserting BufferedInputStream to reduce number of small size reads
directly hitting the file system.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #609 (17e3042) into master (38966f3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #609   +/-   ##
=========================================
  Coverage     72.30%   72.30%           
  Complexity     1573     1573           
=========================================
  Files           127      127           
  Lines          6067     6067           
  Branches        636      636           
=========================================
  Hits           4387     4387           
  Misses         1460     1460           
  Partials        220      220           
Impacted Files Coverage Δ
...io/jenkins/plugins/coverage/CoverageProcessor.java 83.55% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.

Please note that this code actually is part of the deprecated code base. This code is not used when you use the new coverage step recordCoverage.

@uhafner uhafner merged commit 63795e7 into jenkinsci:master Mar 29, 2023
@uhafner uhafner added the bug Bugs or performance problems label Mar 29, 2023
@y-higuchi y-higuchi deleted the buffered-read branch March 29, 2023 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bugs or performance problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants