config: fix compatibility issue

[matttbe]

It seems that the configuration name has changed and this break the
compatibility:

Before (v1.22 or before):

<org.jenkinsci.plugins.cppcheck.CppcheckPublisher>
  <cppcheckConfig>
    <pattern>**/cppcheck.xml</pattern>

After (v1.23):

<org.jenkinsci.plugins.cppcheck.CppcheckPublisher plugin="cppcheck@1.23">
  <config> <!-- Not cppcheckConfig anymore -->
    <pattern>**/cppcheck.xml</pattern>

You can check the generated config.xml file by looking at this address:

https://<JENKINS_URL>/job/<JOBNAME>/config.xml

I am not sure how the XML scheme is generated but I guess it inspects
the name of the variables. Then this change should fix the
compatibility issue.

Linked to this issue: JENKINS-52854
Signed-off-by: Matthieu Baerts matthieu.baerts@tessares.net

[matttbe]

@marcosteffan : I didn't try this but I hope it should fix JENKINS-52854 issue !

[matttbe]

@marcosteffan : I didn't try this but I hope it should fix JENKINS-52854 issue !

I mentioned it on the Jenkins ticket but I forgot to mention it here as well. I did test it and it does fix the Jenkins issue ;-)

[eckschi]

the change in 32710c4 also broke all projects made by https://docs.openstack.org/infra/jenkins-job-builder/ so merging would fix issues there

[matttbe]

@eckschi Yes, I confirm that. Note that you can temporary use the .hpi from https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fcppcheck-plugin/detail/PR-44/2/artifacts/

[janitza-thbe]

@marcosteffan
Please be so kind and merge this PR and release a new version afterwards since my company is badly awaiting for both pipeline support and backward compatibility to our dozens of build jobs w/ old v1.21 configurations that are lost on plugin upgrade.
Thx.

[marcosteffan]

Hi,
that issue should be fixed with https://issues.jenkins-ci.org/browse/JENKINS-52854 which has been released just now.

Best regards

[matttbe]

@marcosteffan : thx you for the fix. I guess we can abandon this one