[JENKINS-29646] - fix bug in constructor call that breaks rebuild-plugin#41
Merged
stephenc merged 1 commit intojenkinsci:masterfrom Feb 15, 2016
Merged
[JENKINS-29646] - fix bug in constructor call that breaks rebuild-plugin#41stephenc merged 1 commit intojenkinsci:masterfrom
stephenc merged 1 commit intojenkinsci:masterfrom
Conversation
-description and value parameters were swapped in constructor call causing the credential parameter value of the previous build to be replaced with a "global" default (i.e. the first credential parameter from the dropdown list) when triggering a rebuild.
Member
|
👍 |
stephenc
added a commit
that referenced
this pull request
Feb 15, 2016
[JENKINS-29646] - fix bug in constructor call that breaks rebuild-plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request swaps the order of 2 parameters in a call to CredentialsParameterDefinition constructor to match the definition. This error caused the Rebuild Plugin to swap the parameter description with the credential GUID when a rebuild was requested. This in turn selected the credential at the top of the dropdown list instead of the credential from the specified build thereby defeating the reason for using the rebuild plugin (see issue JENKINS-29646)
I have been using this for a couple weeks and it has solved the issue with the Rebuild Plugin behaving in the expected manner.