Skip to content

Conversation

@jonesbusy
Copy link
Contributor

Depends on postgresql-api plugin instead

Testing done

Automated tests only

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy
Copy link
Contributor Author

We need to be careful with this due to jenkins-infra/helpdesk#3757

Version is considered older.

We might need to depends on 42.3.3 instead

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can submit a PR doing following "Versioning with wrapped components" on:
https://www.jenkins.io/doc/developer/publishing/releasing-cd/

to the api plugin?

@jonesbusy
Copy link
Contributor Author

Any chance you can submit a PR doing following "Versioning with wrapped components" on: https://www.jenkins.io/doc/developer/publishing/releasing-cd/

to the api plugin?

Sure I can do that. I think it's the best to keep the prefix

@jonesbusy jonesbusy marked this pull request as draft September 20, 2023 14:49
@jonesbusy
Copy link
Contributor Author

Here : jenkinsci/postgresql-api-plugin#61

When released I will update this PR

@jonesbusy jonesbusy force-pushed the feature/depends-api-plugin branch from 797e4b0 to 79fcfa9 Compare September 20, 2023 15:53
@jonesbusy jonesbusy marked this pull request as ready for review September 20, 2023 15:53
@jonesbusy jonesbusy requested a review from timja September 20, 2023 15:59
@timja timja merged commit 59f57c5 into jenkinsci:master Sep 20, 2023
@jonesbusy jonesbusy deleted the feature/depends-api-plugin branch September 21, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants